From: Jens Axboe <axboe@kernel.dk>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: drbd-dev@lists.linux.dev, linux-kernel@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-block@vger.kernel.org,
Vivek Parikh <vivek.parikh@breachx.ai>
Subject: Re: [PATCH] drbd: don't leak the shared secret to unprivileged netlink dumps
Date: Sat, 15 Aug 2026 20:06:39 -0600 [thread overview]
Message-ID: <178684599913.2049660.4334999854490321092.b4-ty@b4> (raw)
In-Reply-To: <20260814151617.73752-1-christoph.boehmwalder@linbit.com>
On Fri, 14 Aug 2026 17:16:17 +0200, Christoph Böhmwalder wrote:
> The conversion to explicit netlink serialization dropped the
> exclude_sensitive parameter from net_conf_to_skb(), so each caller has
> to sanitize by hand. Two dump paths were missed:
> drbd_nl_get_connections_dumpit() and the volume-less connection branch
> of get_one_status(). Neither op carries GENL_ADMIN_PERM, so any
> unprivileged local user could read the CRAM-HMAC secret.
>
> [...]
Applied, thanks!
[1/1] drbd: don't leak the shared secret to unprivileged netlink dumps
commit: c71bf113dfdf426bdaf106636f573ef87b6613a0
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2026-08-16 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 15:16 [PATCH] drbd: don't leak the shared secret to unprivileged netlink dumps Christoph Böhmwalder
2026-08-16 2:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178684599913.2049660.4334999854490321092.b4-ty@b4 \
--to=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=drbd-dev@lists.linux.dev \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=vivek.parikh@breachx.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox