From: Sagi Grimberg <sagi@grimberg.me>
To: Gulam Mohamed <gulam.mohamed@oracle.com>, linux-block@vger.kernel.org
Cc: nvdimm@lists.linux.dev, shminderjit.singh@oracle.com,
linux-kernel@vger.kernel.org, song@kernel.org,
dm-devel@redhat.com, ira.weiny@intel.com, agk@redhat.com,
drbd-dev@lists.linbit.com, dave.jiang@intel.com,
vishal.l.verma@intel.com, konrad.wilk@oracle.com,
joe.jin@oracle.com, kent.overstreet@gmail.com, ngupta@vflare.org,
kch@nvidia.com, senozhatsky@chromium.org, snitzer@kernel.org,
colyli@suse.de, linux-raid@vger.kernel.org,
linux-bcache@vger.kernel.org, dan.j.williams@intel.com,
axboe@kernel.dk, martin.petersen@oracle.com,
rajesh.sivaramasubramaniom@oracle.com,
philipp.reisner@linbit.com, junxiao.bi@oracle.com,
minchan@kernel.org, lars.ellenberg@linbit.com
Subject: Re: [Drbd-dev] [PATCH for-6.2/block V3 1/2] block: Data type conversion for IO accounting
Date: Sun, 25 Dec 2022 13:40:23 +0200 [thread overview]
Message-ID: <1d0eb8e4-a91f-4635-bac7-9bc6cefbeff0@grimberg.me> (raw)
In-Reply-To: <20221221040506.1174644-1-gulam.mohamed@oracle.com>
On 12/21/22 06:05, Gulam Mohamed wrote:
> Change the data type of start and end time IO accounting variables in,
> block layer, from "unsigned long" to "u64". This is to enable nano-seconds
> granularity, in next commit, for the devices whose latency is less than
> milliseconds.
>
> Changes from V2 to V3
> =====================
> 1. Changed all the required variables data-type to u64 as part of this
> first patch
> 2. Create a new setting '2' for iostats in sysfs in next patch
> 3. Change the code to get the ktime values when iostat=2 in next patch
>
> Signed-off-by: Gulam Mohamed <gulam.mohamed@oracle.com>
> ---
> block/blk-core.c | 24 ++++++++++++------------
> block/blk.h | 2 +-
> drivers/block/drbd/drbd_int.h | 2 +-
> drivers/block/zram/zram_drv.c | 4 ++--
> drivers/md/bcache/request.c | 10 +++++-----
> drivers/md/dm-core.h | 2 +-
> drivers/md/dm.c | 2 +-
> drivers/md/md.h | 2 +-
> drivers/md/raid1.h | 2 +-
> drivers/md/raid10.h | 2 +-
> drivers/md/raid5.c | 2 +-
> drivers/nvdimm/btt.c | 2 +-
> drivers/nvdimm/pmem.c | 2 +-
> include/linux/blk_types.h | 2 +-
> include/linux/blkdev.h | 12 ++++++------
> include/linux/part_stat.h | 2 +-
nvme-mpath now also has stats, so struct nvme_request should also be
updated.
prev parent reply other threads:[~2022-12-25 11:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 4:05 [Drbd-dev] [PATCH for-6.2/block V3 1/2] block: Data type conversion for IO accounting Gulam Mohamed
2022-12-21 4:05 ` [Drbd-dev] [PATCH for-6.2/block V3 2/2] block: Change the granularity of io ticks from ms to ns Gulam Mohamed
2022-12-21 16:18 ` kernel test robot
2022-12-21 17:09 ` Keith Busch
2022-12-23 14:47 ` Gulam Mohamed
2022-12-21 22:54 ` kernel test robot
2022-12-24 1:27 ` kernel test robot
2023-01-17 17:52 ` Mike Snitzer
2022-12-21 9:25 ` [Drbd-dev] [PATCH for-6.2/block V3 1/2] block: Data type conversion for IO accounting kernel test robot
2022-12-21 16:29 ` kernel test robot
2022-12-22 15:37 ` kernel test robot
2022-12-25 11:40 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d0eb8e4-a91f-4635-bac7-9bc6cefbeff0@grimberg.me \
--to=sagi@grimberg.me \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=gulam.mohamed@oracle.com \
--cc=ira.weiny@intel.com \
--cc=joe.jin@oracle.com \
--cc=junxiao.bi@oracle.com \
--cc=kch@nvidia.com \
--cc=kent.overstreet@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=nvdimm@lists.linux.dev \
--cc=philipp.reisner@linbit.com \
--cc=rajesh.sivaramasubramaniom@oracle.com \
--cc=senozhatsky@chromium.org \
--cc=shminderjit.singh@oracle.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox