From: Lars Marowsky-Bree <lmb@suse.de>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [fix] drbd uses wrong API for struct bio
Date: Tue, 25 Jan 2005 11:05:16 +0100 [thread overview]
Message-ID: <20050125100516.GC5638@marowsky-bree.de> (raw)
In-Reply-To: <200501251058.15982.philipp.reisner@linbit.com>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
On 2005-01-25T10:58:13, Philipp Reisner <philipp.reisner@linbit.com> wrote:
> When are you taking the code for SuSE ?
Today. We're in a bit of a hurry because we screwed up and shipped the
oopsing drbd in SP1 ;-)
> I guess it would make sense to tag drbd-0.7.8 at that moment, so
> that this time SuSE and the rest of the world have the same
> "drbd-0.7.8" :)
Sure. Attached is the minimal cleanup Jens suggested relative to svn
1732.
Sincerely,
Lars Marowsky-Brée <lmb@suse.de>
--
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business
[-- Attachment #2: drbd-50103 --]
[-- Type: text/plain, Size: 776 bytes --]
Index: drbd/drbd_compat_wrappers.h
===================================================================
--- drbd/drbd_compat_wrappers.h (revision 1732)
+++ drbd/drbd_compat_wrappers.h (working copy)
@@ -471,8 +471,7 @@
bio->bi_destructor = NULL;
vec->bv_page = page;
bio->bi_size = vec->bv_len = PAGE_SIZE;
- bio->bi_max_vecs = bio->bi_vcnt =
- bio->bi_phys_segments = bio->bi_hw_segments = 1;
+ bio->bi_max_vecs = bio->bi_vcnt = 1;
vec->bv_offset = 0;
e->block_id = ID_VACANT;
@@ -504,8 +503,7 @@
bio->bi_destructor = NULL;
vec->bv_page = page;
vec->bv_offset = 0;
- bio->bi_max_vecs = bio->bi_vcnt =
- bio->bi_phys_segments = bio->bi_hw_segments = 1;
+ bio->bi_max_vecs = bio->bi_vcnt = 1;
bio->bi_bdev = mdev->backing_bdev;
bio->bi_private = mdev;
next prev parent reply other threads:[~2005-01-25 10:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-23 16:16 [Drbd-dev] drbd uses wrong API for struct bio Lars Marowsky-Bree
2005-01-24 8:24 ` [Drbd-dev] " Jens Axboe
2005-01-24 12:32 ` Helmut Wollmersdorfer
2005-01-24 12:35 ` Lars Marowsky-Bree
2005-01-24 9:10 ` Jens Axboe
2005-01-24 9:28 ` Lars Marowsky-Bree
2005-01-24 9:58 ` Lars Marowsky-Bree
2005-01-24 10:23 ` Jens Axboe
2005-01-24 10:28 ` Lars Marowsky-Bree
2005-01-24 12:24 ` Lars Marowsky-Bree
2005-01-24 12:52 ` Lars Marowsky-Bree
2005-01-24 14:29 ` Philipp Reisner
2005-01-26 11:15 ` Lars Ellenberg
2005-01-24 14:27 ` Philipp Reisner
2005-01-24 14:27 ` [Drbd-dev] " Philipp Reisner
2005-01-24 14:37 ` Lars Marowsky-Bree
2005-01-24 14:38 ` Philipp Reisner
2005-01-24 14:41 ` Lars Marowsky-Bree
2005-01-24 20:46 ` Lars Marowsky-Bree
2005-01-24 23:23 ` [Drbd-dev] [fix] " Lars Marowsky-Bree
2005-01-25 9:26 ` Philipp Reisner
2005-01-25 9:39 ` Jens Axboe
2005-01-25 9:58 ` Philipp Reisner
2005-01-25 10:05 ` Lars Marowsky-Bree [this message]
2005-01-25 11:44 ` Philipp Reisner
2005-01-25 9:53 ` Lars Marowsky-Bree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050125100516.GC5638@marowsky-bree.de \
--to=lmb@suse.de \
--cc=drbd-dev@lists.linbit.com \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox