From: Philipp Reisner <philipp.reisner@linbit.com>
To: axboe@suse.de
Cc: Lars Marowsky-Bree <lmb@suse.de>, drbd-dev@lists.linbit.com
Subject: [Drbd-dev] Re: bio clone must copy io_vec
Date: Thu, 27 Jan 2005 10:47:09 +0100 [thread overview]
Message-ID: <200501271047.09852.philipp.reisner@linbit.com> (raw)
Hi all,
I am reffering to Jens' fix for md...
> The way md uses bio_clones, it's possible for the original bio to be freed
> before the clone is freed. This means the clone ->bi_io_vec points to freed
> memory potentially. Fix it by duplicating the io_vec as well.
[...]
In DRBD the thing is different.
We use __bio_clone() but we will never end IO for our original bio before
we have not finished IO for our cloned BIO.
My fist thought was to have a own copy of __bio_clone() in place, which
behaves like the __bio_clone() of Linux-2.6.10-vanilla.
But on the other hand I think I can convert it over to use bio_clone()
within a few hours. Well I will give it a try, and let you know if
I end up with a patch...
PS: Jens, when I am the owner of a BIO I can do with the private
member what ever I want, right ?
And I am the owner of a bio clones with bio_clone() right ?
-Philipp
--
: Dipl-Ing Philipp Reisner Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria http://www.linbit.com :
next reply other threads:[~2005-01-27 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-27 9:47 Philipp Reisner [this message]
[not found] ` <20050127111242.GX5511@marowsky-bree.de>
[not found] ` <20050127111827.GN2751@suse.de>
2005-01-27 11:38 ` [Drbd-dev] Re: bio clone must copy io_vec Philipp Reisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501271047.09852.philipp.reisner@linbit.com \
--to=philipp.reisner@linbit.com \
--cc=axboe@suse.de \
--cc=drbd-dev@lists.linbit.com \
--cc=lmb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox