From: Lars Marowsky-Bree <lmb@suse.de>
To: Philipp Reisner <philipp.reisner@linbit.com>, drbd-dev@lists.linbit.com
Cc: Jens Axboe <axboe@suse.de>
Subject: Re: [Drbd-dev] Re: [DRBD-cvs] r1743 - in branches/drbd-0.7: . drbd
Date: Thu, 3 Feb 2005 10:15:56 +0100 [thread overview]
Message-ID: <20050203091556.GO7628@marowsky-bree.de> (raw)
In-Reply-To: <200502021859.10633.philipp.reisner@linbit.com>
On 2005-02-02T18:59:10, Philipp Reisner <philipp.reisner@linbit.com> wrote:
> Why do you not simply read the code ?
I did, but because the comments in the code and those I got from Jens were
contradictionary with what you said, and I wanted to figure out who was
right, and I'm known to misunderstand code.
But Jens confirmed in a private discussion that you're right ;-)
Normally, the end_io functions would drop their reference count. Alas,
because drbd and md were converted from on stack bios, those didn't.
So yes, the additional bio_get seems to be wrong indeed, or a bio_put()
should be added to the end_io.
Thanks for catching this, this means we'll have another bugfix queued
soon...
Sincerely,
Lars Marowsky-Brée <lmb@suse.de>
--
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business
prev parent reply other threads:[~2005-02-03 9:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050131111921.EE6F83BE6D@garcon.linbit.com>
2005-02-01 16:48 ` [Drbd-dev] Re: [DRBD-cvs] r1743 - in branches/drbd-0.7: . drbd Lars Marowsky-Bree
2005-02-01 17:36 ` Philipp Reisner
2005-02-02 10:13 ` Lars Marowsky-Bree
2005-02-02 17:59 ` Philipp Reisner
2005-02-03 8:38 ` Jens Axboe
2005-02-03 9:15 ` Lars Marowsky-Bree [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050203091556.GO7628@marowsky-bree.de \
--to=lmb@suse.de \
--cc=axboe@suse.de \
--cc=drbd-dev@lists.linbit.com \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox