From: Philipp Reisner <philipp.reisner@linbit.com>
To: Jens Axboe <axboe@suse.de>
Cc: drbd-dev@linbit.com
Subject: [Drbd-dev] bio_split()...
Date: Tue, 15 Mar 2005 21:15:58 +0100 [thread overview]
Message-ID: <200503152115.58219.philipp.reisner@linbit.com> (raw)
Hi Jens,
bio_split only works for bios with a single page...
[ from bio.c: ]
/*
* split a bio - only worry about a bio with a single page
* in it's iovec
*/
struct bio_pair *bio_split(struct bio *bi, mempool_t *pool, int first_sectors)
{
struct bio_pair *bp = mempool_alloc(pool, GFP_NOIO);
if (!bp)
return bp;
BUG_ON(bi->bi_vcnt != 1);
[...]
In DRBD-0.8 I want to split BIO's that cross a 16 MB boundary.
In DRBD-0.8 I accept BIOs with more than one page (currently up to
32 kB in a single BIO), I thought that bio_split is here
to handle such situations....
Is there an other way to go ?
Would you accept a patch that would make bio_split to work with bigger
BIOs ?
Currently my code hits that BUG_ON statement....
-Philipp
next reply other threads:[~2005-03-15 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 20:15 Philipp Reisner [this message]
2005-03-15 20:24 ` [Drbd-dev] Re: bio_split() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503152115.58219.philipp.reisner@linbit.com \
--to=philipp.reisner@linbit.com \
--cc=axboe@suse.de \
--cc=drbd-dev@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox