Re: [Drbd-dev] Large data requests

[Lars Ellenberg <Lars.Ellenberg@linbit.com>]

/ 2006-07-18 09:59:21 -0400
\ Graham, Simon:
> This seems too easy to be a bug, but I've been getting occasional errors
> with DRBD-8 (latest trunk as of yesterday) like this:
> 
> Jul 17 16:25:03 jake kernel: drbd2: receive_DataReply: (data_size >
> PAGE_SIZE) in /sandbox/sgraham/sn/trunk/drbd-8/drbd/drbd_receiver.c:1035
> 
> The line in question being:
> 
> 	ERR_IF(data_size >  PAGE_SIZE) return FALSE;
> 
> in receive_DataReply. Now, one of the changes in DRBD-8 was to allow
> requests up to 32K to be passed down and it looks to me like these are
> just passed on to the remote side (if the local side does not have good
> data) so it would be perfectly OK to receive a DataReply > 4KB in size -
> is this just a left over assert that needs to be removed? Or did I miss
> something?

thanks.
committed as:
-       ERR_IF(data_size >  PAGE_SIZE) return FALSE;
+       ERR_IF(data_size >  DRBD_MAX_SEGMENT_SIZE) return FALSE;


-- 
: Lars Ellenberg                                  Tel +43-1-8178292-55 :
: LINBIT Information Technologies GmbH            Fax +43-1-8178292-82 :
: Schoenbrunner Str. 244, A-1120 Vienna/Europe   http://www.linbit.com :