Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Philipp Reisner <philipp.reisner@linbit.com>
To: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] DRBD-8 trunk crashes if NegDReply received in reply toRSDataRequest
Date: Tue, 8 Aug 2006 17:01:47 +0200	[thread overview]
Message-ID: <200608081701.48009.philipp.reisner@linbit.com> (raw)
In-Reply-To: <342BAC0A5467384983B586A6B0B3767103471180@EXNA.corp.stratus.com>

Am Sonntag, 6. August 2006 18:18 schrieb Graham, Simon:
> Oh wait... that wont work -- the call to send the negative ack takes the
> epoch_entry* as a parameter...
>
> How about having a new routine that can send a negative ack based on a
> Data packet pointer? I don't like the idea of making drbd_aloc_ee able
> to handle this case as you will get a partially initialized epoch_entry*
> back in that case...
>

Again, I agree completely.

In adition I looked out for more drbd_alloc_ee() and moved them after
the inc_local() statement....

Please check my patch
http://lists.linbit.com/pipermail/drbd-cvs/2006-August/001180.html

-philipp
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria    http://www.linbit.com :

  reply	other threads:[~2006-08-08 15:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-06 16:18 [Drbd-dev] DRBD-8 trunk crashes if NegDReply received in reply toRSDataRequest Graham, Simon
2006-08-08 15:01 ` Philipp Reisner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-08-08 13:45 Graham, Simon
2006-08-06 16:14 Graham, Simon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200608081701.48009.philipp.reisner@linbit.com \
    --to=philipp.reisner@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox