Re: [Drbd-dev] PATCH: Missing state change netlink events

[Philipp Reisner <philipp.reisner@linbit.com>]

On Tuesday 06 November 2007 13:41:34 Graham, Simon wrote:
> > > I think the fix is simple - modify the code so that after_state_ch
> > > broadcasts the new state rather than the current state (patch
> >
> > attached)
> >
> > > - I would have removed the passing of mdev completely from
> > > drbd_bcast_state() if it weren't for the fact it is required by the
> > > generated to_tags function. I'm testing this at the moment but it's
>
> a
>
> > > little hard to be sure it's right since this requires fairly tight
> > > timing.
> >
> > Hi Simon,
> >
> > You are right. Obviously.
> > I have put it into GIT.
>
> Actually, this patch wasn't quite complete -- there were a couple of
> places where the wrong new state was broadcast (where ScheduleAfter was
> _not_ set in the call to _drbd_set_state). Patch attached.
>

Right.

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Vivenotgasse 48, 1120 Vienna, Austria        http://www.linbit.com :