Re: [Drbd-dev] 8.2.6 Peer disk state handling issue when attaching

[Philipp Reisner <philipp.reisner@linbit.com>]

Am Montag 15 September 2008 20:26:15 schrieb Petrakis, Peter:
> Hi All,
>
> We've evolved the original patch to the following, which seems to solve
> our problem. Can you see anything wrong with it? Thanks.
>
> diff -r f9aa469f7044 drbd_main.c
> --- a/drbd_main.c       Fri Sep 12 13:51:40 2008 -0400
> +++ b/drbd_main.c       Mon Sep 15 10:04:48 2008 -0400
> @@ -765,7 +765,7 @@
>                 ns.conn = Connected;
>         }
>
> -       if (ns.conn != os.conn && ns.conn >= Connected &&
> +       if (ns.conn >= Connected &&
>             (ns.disk == Consistent || ns.disk == Outdated)) {
>                 switch(ns.conn) {
>                 case WFBitMapT:
> @@ -787,7 +787,7 @@
>                         WARN("Implicit set disk from Outdate to
> UpToDate\n");
>         }
>
> -       if (ns.conn != os.conn && ns.conn >= Connected &&
> +       if (ns.conn >= Connected &&
>             (ns.pdsk == Consistent || ns.pdsk == Outdated)) {
>                 switch(ns.conn) {
>                 case Connected:
>
>

Hi Peter,

There is nothing wrong with that patch. It is just my failure to follow
drbd-dev for the last month...

I have committed now nearly that code change upstream. You will
find it there soon as 00f2ce70e0daaa72775b3712863fb29ee99581f3
(in drbd-8.0) and from there it will be propagated to 8.2 of 
course.

-phil
-- 
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com

DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.