Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruen@linbit.com>
To: Thomas Zeitlhofer <thomas.zeitlhofer@nt.tuwien.ac.at>
Cc: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] initialize tconn->peer_integrity_tfm in drbd_adm_connect()
Date: Mon, 25 Jul 2011 11:39:45 +0200	[thread overview]
Message-ID: <201107251139.45806.agruen@linbit.com> (raw)
In-Reply-To: <20110724233847.GA2356@swan.nt.tuwien.ac.at>

Thomas,

On Monday 25 July 2011 01:38:48 Thomas Zeitlhofer wrote:
> The support for data-integrity-alg seems to be broken with drbd-8.4.0.
> E.g., when trying to resync, the SyncTarget hits:
> 
>    ASSERTION IS_ALIGNED(data_size, 512) FAILED in read_in_block
>    error receiving RSDataReply, e: -5 l: 126996! read_in_block
> 
> This is caused by an uninitialized tconn->peer_integrity_tfm. Therefore,
> the digest data is not used/removed at the receiver which leads to
> additional 20 bytes that trigger the assertion above.

thanks for tracking this down.  Your analysis and the fix are correct.  As it 
happens, we also ran into this bug here meanwhile.  Here is what we did to 
address it:

  http://git.drbd.org/?p=drbd-8.4.git;a=commit;h=4811eceb393c274f94bfd8926e714d6271cf1f57

The two fixes are slightly different, but both should do the job.  Sorry for 
not letting you know of our fix in time.

The master branch in http://git.drbd.org/?p=drbd-8.4.git contains a few 
additional minor fixes.

Thanks,
Andreas

  reply	other threads:[~2011-07-25  9:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-24 23:38 [Drbd-dev] [PATCH] initialize tconn->peer_integrity_tfm in drbd_adm_connect() Thomas Zeitlhofer
2011-07-25  9:39 ` Andreas Gruenbacher [this message]
2011-07-25 12:36   ` Thomas Zeitlhofer
2011-07-25 12:47     ` Andreas Gruenbacher
2011-07-25 13:09       ` Thomas Zeitlhofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201107251139.45806.agruen@linbit.com \
    --to=agruen@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=thomas.zeitlhofer@nt.tuwien.ac.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox