From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Michal Marek <mmarek@suse.cz>
Cc: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: Fix build on bigendian
Date: Tue, 6 Sep 2011 19:16:17 +0200 [thread overview]
Message-ID: <20110906171617.GD4449@barkeeper1-xen.linbit> (raw)
In-Reply-To: <1315310652-19078-1-git-send-email-mmarek@suse.cz>
On Tue, Sep 06, 2011 at 02:04:12PM +0200, Michal Marek wrote:
> Remove the superfluous <asm-generic/bitops/le.h> include and fix the
> have_find_next_zero_bit_le test ('NULL' undeclared).
Thanks, but...
Hm. That may help you get it working there.
But it will likely break for other still supported kernel versions.
We probably need to figure out a different fix.
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
> drbd/compat/tests/have_find_next_zero_bit_le.c | 2 +-
> drbd/drbd_bitmap.c | 2 --
> 2 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drbd/compat/tests/have_find_next_zero_bit_le.c b/drbd/compat/tests/have_find_next_zero_bit_le.c
> index 901e4b3..4338511 100644
> --- a/drbd/compat/tests/have_find_next_zero_bit_le.c
> +++ b/drbd/compat/tests/have_find_next_zero_bit_le.c
> @@ -1,5 +1,5 @@
> +#include <linux/stddef.h>
> #include <linux/bitops.h>
> -#include <asm-generic/bitops/le.h>
>
> unsigned long func(void)
> {
> diff --git a/drbd/drbd_bitmap.c b/drbd/drbd_bitmap.c
> index 342aa08..4d4587e 100644
> --- a/drbd/drbd_bitmap.c
> +++ b/drbd/drbd_bitmap.c
> @@ -30,8 +30,6 @@
> #include <linux/dynamic_debug.h>
> #include <asm/kmap_types.h>
>
> -#include <asm-generic/bitops/le.h>
> -
> #include "drbd_int.h"
>
> /* See the ifdefs and comments inside that header file.
> --
> 1.7.6
>
> _______________________________________________
> drbd-dev mailing list
> drbd-dev@lists.linbit.com
> http://lists.linbit.com/mailman/listinfo/drbd-dev
--
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com
DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.
prev parent reply other threads:[~2011-09-06 17:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 12:04 [Drbd-dev] [PATCH] drbd: Fix build on bigendian Michal Marek
2011-09-06 17:16 ` Lars Ellenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906171617.GD4449@barkeeper1-xen.linbit \
--to=lars.ellenberg@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox