Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	drbd-user@lists.linbit.com, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drivers/block/drbd: remove erroneous semicolon
Date: Mon, 8 Apr 2013 22:45:10 +0200	[thread overview]
Message-ID: <20130408204510.GB13761@soda.linbit> (raw)
In-Reply-To: <515BE19F.2080709@asianux.com>

On Wed, Apr 03, 2013 at 04:00:31PM +0800, Chen Gang wrote:
> Hello maintainers:
> 
>   when you have time, please help to check this patch whether is OK.
> 
>   thanks.

Thanks.

It has already been queued in:
http://git.kernel.dk/?p=linux-block.git;a=commit;h=0b6ef4164f50698eee536903d69d086add1a7889

> On 2013年03月27日 14:56, Chen Gang wrote:
> > 
> >   need remove it, or always return -EBUSY.
> >   it is found by compiler with 'EXTRA_CFLAG=-W'.
> > 
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> > ---
> >  drivers/block/drbd/drbd_actlog.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c
> > index 6afe173..6608076 100644
> > --- a/drivers/block/drbd/drbd_actlog.c
> > +++ b/drivers/block/drbd/drbd_actlog.c
> > @@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i)
> >  		if (unlikely(tmp != NULL)) {
> >  			struct bm_extent  *bm_ext = lc_entry(tmp, struct bm_extent, lce);
> >  			if (test_bit(BME_NO_WRITES, &bm_ext->flags)) {
> > -				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags));
> > +				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags))
> >  					return -EBUSY;
> >  				return -EWOULDBLOCK;
> >  			}
> > 

       reply	other threads:[~2013-04-08 20:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5152980D.8090903@asianux.com>
     [not found] ` <515BE19F.2080709@asianux.com>
2013-04-08 20:45   ` Lars Ellenberg [this message]
2013-04-09  1:22     ` [Drbd-dev] [PATCH] drivers/block/drbd: remove erroneous semicolon Chen Gang
2013-04-09 15:56       ` Lars Ellenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130408204510.GB13761@soda.linbit \
    --to=lars.ellenberg@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=drbd-user@lists.linbit.com \
    --cc=gang.chen@asianux.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox