Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] stonith-related regression introduced around kernel 3.13, with 3.15.3 still affected
Date: Mon, 7 Jul 2014 11:03:07 +0200	[thread overview]
Message-ID: <20140707090307.GC1229@soda.linbit> (raw)
In-Reply-To: <201407071041.33545.mmazur@kernel.pl>

On Mon, Jul 07, 2014 at 10:41:33AM +0200, Mariusz Mazur wrote:
> On Fri of July 4 2014, Lars Ellenberg wrote:
> 
> > Yeah, sorry, typo, leave off the pending-.
> > 
> > It's flush_signals(current);
> > 
> > diff --git a/drbd/drbd_nl.c b/drbd/drbd_nl.c
> > index 9e6adaa..d8b83d7 100644
> > --- a/drbd/drbd_nl.c
> > +++ b/drbd/drbd_nl.c
> > @@ -586,6 +586,7 @@ void conn_try_outdate_peer_async(struct drbd_connection
> > *connection) struct task_struct *opa;
> > 
> >  	kref_get(&connection->kref);
> > +	flush_signals(current);
> >  	opa = kthread_run(_try_outdate_peer_async, connection, "drbd_async_h");
> >  	if (IS_ERR(opa)) {
> >  		drbd_err(connection, "out of mem, failed to invoke fence-peer
> > helper\n");
> 
> Yup, this worked. Should it maybe get sent upstream to the kernel? :)

Yes Sir Captain Obvious Sir.

 ;-)

Thanks for confirming, anyways.

	Lars

-- 
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.

      reply	other threads:[~2014-07-07  9:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03 13:07 [Drbd-dev] stonith-related regression introduced around kernel 3.13, with 3.15.3 still affected Mariusz Mazur
2014-07-03 13:44 ` Lars Ellenberg
2014-07-03 13:54   ` Lars Ellenberg
2014-07-03 17:49     ` Mariusz Mazur
2014-07-04 11:42       ` Lars Ellenberg
2014-07-07  8:41         ` Mariusz Mazur
2014-07-07  9:03           ` Lars Ellenberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140707090307.GC1229@soda.linbit \
    --to=lars.ellenberg@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox