From: Christoph Hellwig <hch@infradead.org>
To: Dongsu Park <dongsu.park@profitbricks.com>
Cc: Jens Axboe <axboe@kernel.dk>, Oleg Drokin <oleg.drokin@intel.com>,
Nitin Gupta <ngupta@vflare.org>,
Mike Snitzer <snitzer@redhat.com>, Ming Lin <mlin@minggr.net>,
Minchan Kim <minchan@kernel.org>, Neil Brown <neilb@suse.de>,
Jiri Kosina <jkosina@suse.cz>, Ming Lei <ming.lei@canonical.com>,
linux-kernel@vger.kernel.org, Jim Paris <jim@jtan.com>,
Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Geoff Levand <geoff@infradead.org>,
Kent Overstreet <kmo@daterainc.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <andreas.dilger@intel.com>,
dm-devel@redhat.com, Joshua Morris <josh.h.morris@us.ibm.com>,
Alasdair Kergon <agk@redhat.com>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [RFC PATCH 01/17] block: make generic_make_request handle arbitrarily sized bios
Date: Tue, 23 Dec 2014 02:16:14 -0800 [thread overview]
Message-ID: <20141223101614.GA13138@infradead.org> (raw)
In-Reply-To: <d26a9a0fc9a7d1529c115785ee5935d5750782bd.1419241597.git.dongsu.park@profitbricks.com>
> +void blk_queue_split(struct request_queue *q, struct bio **bio,
> + struct bio_set *bs)
> +{
> + struct bio *split;
> +
> + if ((*bio)->bi_rw & REQ_DISCARD)
> + split = blk_bio_discard_split(q, *bio, bs);
> + else if ((*bio)->bi_rw & REQ_WRITE_SAME)
> + split = blk_bio_write_same_split(q, *bio, bs);
> + else
> + split = blk_bio_segment_split(q, *bio, q->bio_split);
> +
> + if (split) {
> + bio_chain(split, *bio);
> + generic_make_request(*bio);
> + *bio = split;
> + }
> +}
> +EXPORT_SYMBOL(blk_queue_split);
I think blk_queue_split needs to explicitly skip BLOCK_PC bios. Those
are SCSI pass through ioctls that we can't split due to their opaque
nature.
next prev parent reply other threads:[~2014-12-23 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1419241597.git.dongsu.park@profitbricks.com>
2014-12-22 11:48 ` [Drbd-dev] [RFC PATCH 01/17] block: make generic_make_request handle arbitrarily sized bios Dongsu Park
[not found] ` <f67d71b4a375ab504c2fc02e94a9d2a651686cab.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <fe96db02d805ca6191dd605d03dac0d04c926fc1.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <bb0051ceb5805896089ded26c0f7f06758b25105.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <e4b7b017eaa81784889ebb2a4e6a7d4366adf13a.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <83a9ee8a309f8e08490c5dd715a608ea054f5c33.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <fc859b23b383f6f4c1e81f4210aa62cb1bdc935f.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <0b6ba533a64aec98e8447bfd30c6622d0729d12e.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <d42dae3d2a64fa4c3a0893f1af963151b31869e3.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <4334b90a56b96ad7a11e4ba7eb97c2cf4405950d.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <abe647cf7cf272220227fad4dac9c43641192f01.1419241597.git.dongsu.park@profitbricks.com>
[not found] ` <b7767767957ca758ac492e94dfb320bea4f52dd7.1419241597.git.dongsu.park@profitbricks.com>
2014-12-23 10:16 ` Christoph Hellwig [this message]
2014-12-23 11:41 ` Dongsu Park
2014-12-27 15:02 ` Christoph Hellwig
2014-12-22 11:48 ` [Drbd-dev] [RFC PATCH 14/17] block: kill merge_bvec_fn() completely Dongsu Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141223101614.GA13138@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=andreas.dilger@intel.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=dongsu.park@profitbricks.com \
--cc=drbd-dev@lists.linbit.com \
--cc=geoff@infradead.org \
--cc=jim@jtan.com \
--cc=jkosina@suse.cz \
--cc=josh.h.morris@us.ibm.com \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ming.lei@canonical.com \
--cc=mlin@minggr.net \
--cc=neilb@suse.de \
--cc=ngupta@vflare.org \
--cc=oleg.drokin@intel.com \
--cc=pjk1939@linux.vnet.ibm.com \
--cc=snitzer@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox