From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra13.linbit.com (zimbra.linbit.com [212.69.161.123]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id 08DC81050584 for ; Tue, 10 Mar 2015 11:38:39 +0100 (CET) Date: Tue, 10 Mar 2015 11:38:38 +0100 From: Lars Ellenberg To: David Rientjes Message-ID: <20150310103838.GB3961@soda.linbit> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: Jens Axboe , linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [DRBD-user] [patch 1/2] block, drbd: fix drbd_req_new() initialization List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Mar 07, 2015 at 04:24:02PM -0800, David Rientjes wrote: > mempool_alloc() does not support __GFP_ZERO since elements may come from > memory that has already been released by mempool_free(). > > Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly > initialize it to 0. We used to have the explicit memset there, but then changed that, because I was under the impression that since 2007-07-17 d07dbea, Slab allocators: support __GFP_ZERO in all allocators it was supported? Lars Ellenberg