From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [DRBD-user] [PATCH] drbd: drbd_bitmap: Avoid name collision
Date: Tue, 10 Mar 2015 11:54:45 +0100 [thread overview]
Message-ID: <20150310105445.GC3961@soda.linbit> (raw)
In-Reply-To: <1425752066-25196-1-git-send-email-festevam@gmail.com>
On Sat, Mar 07, 2015 at 03:14:26PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Building for ARM64 leads to the following build warnings:
>
> CC drivers/block/drbd/drbd_bitmap.o
> drivers/block/drbd/drbd_bitmap.c:483:0: warning: "BITS_PER_PAGE" redefined
> #define BITS_PER_PAGE (1UL << (PAGE_SHIFT + 3))
Apparently there are more than one consumer of "BITS_PER_PAGE".
The commit that moved the now conflicting definition to pid_namespace.h
itself already refered to a similar "redefined" warning.
Would it not make more sense to have one such definition next to PAGE_SIZE?
Or somewhere central, anyways?
> Fix the warnings by using BITS_PER_PAGE_DRBD and BITS_PER_PAGE_MASK_DRBD
> definitions to avoid the name collision.
Other than that:
Ack.
Lars Ellenberg
next prev parent reply other threads:[~2015-03-10 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 18:14 [Drbd-dev] [PATCH] drbd: drbd_bitmap: Avoid name collision Fabio Estevam
2015-03-10 10:54 ` Lars Ellenberg [this message]
2015-03-10 16:06 ` [Drbd-dev] [DRBD-user] " Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310105445.GC3961@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox