From: Alasdair G Kergon <agk@redhat.com>
To: Ming Lin <mlin@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
Alex Elder <elder@kernel.org>, Sage Weil <sage@inktank.com>,
Mike Snitzer <snitzer@redhat.com>, Neil Brown <neilb@suse.de>,
Jiri Kosina <jkosina@suse.cz>, Dave Chinner <dchinner@redhat.com>,
linux-kernel@vger.kernel.org, Yehuda Sadeh <yehuda@inktank.com>,
linux-raid@vger.kernel.org, dm-devel@redhat.com,
Alasdair Kergon <agk@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
ceph-devel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Kent Overstreet <kent.overstreet@gmail.com>,
drbd-user@lists.linbit.com,
Lars Ellenberg <drbd-dev@lists.linbit.com>
Subject: Re: [Drbd-dev] [PATCH 07/10] block: kill merge_bvec_fn() completely
Date: Tue, 28 Apr 2015 18:31:37 +0100 [thread overview]
Message-ID: <20150428173137.GC12975@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <1430203717-13307-8-git-send-email-mlin@kernel.org>
On Mon, Apr 27, 2015 at 11:48:34PM -0700, Ming Lin wrote:
> As generic_make_request() is now able to handle arbitrarily sized bios,
> it's no longer necessary for each individual block driver to define its
> own ->merge_bvec_fn() callback. Remove every invocation completely.
merge_bvec_fn is also about telling the code building up bios what optimum
maximum size to use.
Have you got some test data to demonstrate that we won't find some situations
where performance is now lost by code building up bios that are far too big
and are always going to have to be split up later?
Alasdair
next prev parent reply other threads:[~2015-05-07 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1430203717-13307-1-git-send-email-mlin@kernel.org>
2015-04-28 6:48 ` [Drbd-dev] [PATCH 01/10] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-04-28 11:43 ` Christoph Hellwig
2015-04-28 16:01 ` Keith Busch
2015-05-06 6:08 ` Ming Lin
2015-05-06 6:48 ` Christoph Hellwig
2015-05-06 7:13 ` Ming Lin
2015-04-28 6:48 ` [Drbd-dev] [PATCH 07/10] block: kill merge_bvec_fn() completely Ming Lin
2015-04-28 17:31 ` Alasdair G Kergon [this message]
2015-04-29 6:32 ` Ming Lin
2015-04-28 22:09 ` NeilBrown
2015-05-04 7:47 ` Ming Lin
2015-05-06 7:10 ` Ming Lin
2015-05-06 7:26 ` Christoph Hellwig
2015-05-06 17:05 ` Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150428173137.GC12975@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=dchinner@redhat.com \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=elder@kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jkosina@suse.cz \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mlin@kernel.org \
--cc=neilb@suse.de \
--cc=sage@inktank.com \
--cc=snitzer@redhat.com \
--cc=yehuda@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox