From: Christoph Hellwig <hch@lst.de>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>, Neil Brown <neilb@suse.de>,
Ming Lei <ming.lei@canonical.com>,
dm-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
Alasdair Kergon <agk@redhat.com>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
Joshua Morris <josh.h.morris@us.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Kent Overstreet <kent.overstreet@gmail.com>,
Nitin Gupta <ngupta@vflare.org>,
Oleg Drokin <oleg.drokin@intel.com>,
Al Viro <viro@zeniv.linux.org.uk>, Ming Lin <mlin@kernel.org>,
Jens Axboe <axboe@kernel.dk>,
Andreas Dilger <andreas.dilger@intel.com>,
Geoff Levand <geoff@infradead.org>, Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org, Jim Paris <jim@jtan.com>,
Minchan Kim <minchan@kernel.org>, Dongsu Park <dpark@posteo.net>,
drbd-user@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios
Date: Mon, 18 May 2015 19:22:59 +0200 [thread overview]
Message-ID: <20150518172259.GA8116@lst.de> (raw)
In-Reply-To: <x49twv9kevg.fsf@segfault.boston.devel.redhat.com>
On Mon, May 18, 2015 at 12:52:03PM -0400, Jeff Moyer wrote:
> > + return bio_split(bio, split_sectors, GFP_NOIO, bs);
>
> Much of this function is cut-n-paste from blk-lib.c. Is there any way
> to factor it out?
The code in blk-lib.c can go away now that any driver that cares
does the split.
> > +static struct bio *blk_bio_segment_split(struct request_queue *q,
> > + struct bio *bio,
> > + struct bio_set *bs)
> > +{
>
> Funny name for a function that also merges segments. ;-) I admit I am
> at a loss for coming up with a better name that won't overflow 80
> columns.
I'd keep the name and add a funny comment instead.
next prev parent reply other threads:[~2015-05-18 17:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1430980461-5235-1-git-send-email-mlin@kernel.org>
2015-05-07 6:34 ` [Drbd-dev] [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-05-18 16:52 ` Jeff Moyer
2015-05-18 17:22 ` Christoph Hellwig [this message]
2015-05-22 7:51 ` Ming Lin
2015-05-20 18:30 ` Ming Lin
2015-05-20 18:58 ` Jeff Moyer
2015-05-20 20:18 ` Ming Lin
2015-05-22 17:49 ` Ming Lin
2015-05-20 12:44 ` Christoph Hellwig
2015-05-20 18:16 ` Ming Lin
2015-05-07 6:34 ` [Drbd-dev] [PATCH v3 08/11] block: kill merge_bvec_fn() completely Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518172259.GA8116@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=andreas.dilger@intel.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=dpark@posteo.net \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=geoff@infradead.org \
--cc=hch@infradead.org \
--cc=jim@jtan.com \
--cc=jkosina@suse.cz \
--cc=jmoyer@redhat.com \
--cc=josh.h.morris@us.ibm.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ming.lei@canonical.com \
--cc=mlin@kernel.org \
--cc=neilb@suse.de \
--cc=ngupta@vflare.org \
--cc=oleg.drokin@intel.com \
--cc=pjk1939@linux.vnet.ibm.com \
--cc=snitzer@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox