From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: drbd-dev@lists.linbit.com, drbd-user@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH 21/39] drbd: drop null test before destroy functions
Date: Thu, 17 Sep 2015 15:47:25 +0200 [thread overview]
Message-ID: <20150917134725.GF7519@soda.linbit> (raw)
In-Reply-To: <1442146532-9100-22-git-send-email-Julia.Lawall@lip6.fr>
On Sun, Sep 13, 2015 at 02:15:14PM +0200, Julia Lawall wrote:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
> \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
Thanks.
Just a note for our external module repo, which is supposed to be
compatible to "all" kernel versions: don't apply,
requires upstream commits
44d7175 mm/dmapool: allow NULL `pool' pointer in dma_pool_destroy()
4e3ca3e mm/mempool: allow NULL `pool' pointer in mempool_destroy()
3942d29 mm/slab_common: allow NULL cache pointer in kmem_cache_destroy()
(v4.3-rc1)
Lars Ellenberg
prev parent reply other threads:[~2015-09-17 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr>
2015-09-13 12:15 ` [Drbd-dev] [PATCH 21/39] drbd: drop null test before destroy functions Julia Lawall
2015-09-17 13:47 ` Lars Ellenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917134725.GF7519@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox