From: Christoph Hellwig <hch@infradead.org>
To: Mike Christie <mchristi@redhat.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>,
linux-fsdevel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [dm-devel] [PATCH 19/32] block: add helper to get data dir from op
Date: Sat, 7 Nov 2015 02:19:32 -0800 [thread overview]
Message-ID: <20151107101932.GC12117@infradead.org> (raw)
In-Reply-To: <563B930F.7040705@redhat.com>
On Thu, Nov 05, 2015 at 11:34:07AM -0600, Mike Christie wrote:
> I can do that. You are right in how they are used. I just did the above,
> to follow the other *_data_dir calls.
I think the *_data_dir calls are horrible interfaces. But your series
already is huge, so if it makes your life easier I'd say keep it as-is
for now. But in the long run we should have the interfaces that Bart
suggested, and one that gives you a dma_data_direction from a request,
as that's what a lot of the driver ultimatively want.
next prev parent reply other threads:[~2015-11-07 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446674909-5371-1-git-send-email-mchristi@redhat.com>
[not found] ` <1446674909-5371-20-git-send-email-mchristi@redhat.com>
2015-11-04 22:44 ` [Drbd-dev] [dm-devel] [PATCH 19/32] block: add helper to get data dir from op Bart Van Assche
[not found] ` <563B930F.7040705@redhat.com>
2015-11-07 10:19 ` Christoph Hellwig [this message]
2015-11-07 10:10 ` [Drbd-dev] [RESEND RFC PATCH 00/32] separate operations from flags in the bio/request structs Christoph Hellwig
[not found] ` <1446674909-5371-7-git-send-email-mchristi@redhat.com>
2015-11-07 10:17 ` [Drbd-dev] [PATCH 06/32] xen blkback: prepare for bi_rw split Christoph Hellwig
[not found] ` <1446674909-5371-33-git-send-email-mchristi@redhat.com>
2015-11-07 10:21 ` [Drbd-dev] [PATCH 32/32] block: remove __REQ op defs and reduce bi_op/bi_rw sizes Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151107101932.GC12117@infradead.org \
--to=hch@infradead.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mchristi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox