From: Christoph Hellwig <hch@infradead.org>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>,
linux-fsdevel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs
Date: Sat, 7 Nov 2015 02:23:09 -0800 [thread overview]
Message-ID: <20151107102309.GE12117@infradead.org> (raw)
In-Reply-To: <563A3813.5010604@cs.wisc.edu>
On Wed, Nov 04, 2015 at 10:53:39AM -0600, Mike Christie wrote:
> > If you have to touch submit_bio() and submit_bio_wait(), how about
> > requiring the callers of these functions to set the cmd and flags
> > arguments in the bio structure and to leave out the cmd and flags
> > arguments from the submit_bio() and submit_bio_wait() functions ? A
> > (compile tested only) patch that implements this idea is available at
> > https://lkml.org/lkml/2014/6/2/173.
> >
>
> Yeah, I can do that.
I think this would be useful to do at the beginning of the series.
While this will have a huge trickle effect through the series it should
make thing a bit simpler overall. By leaving op 0 undefined it should
also help to create a nice error trap for unconverted code.
next prev parent reply other threads:[~2015-11-07 10:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 16:32 [Drbd-dev] [RFC PATCH 00/32] separate operations from flags in the bio/request structs mchristi
2015-11-04 16:32 ` [Drbd-dev] [PATCH 01/32] block/fs: add REQ_OP definitions mchristi
2015-11-04 16:32 ` [Drbd-dev] [PATCH 02/32] block/fs/mm: prepare submit_bio_wait users for bi_rw split mchristi
2015-11-04 16:32 ` [Drbd-dev] [PATCH 03/32] dio/btrfs: prep dio->submit_bio " mchristi
2015-11-04 16:32 ` [Drbd-dev] [PATCH 04/32] block: prepare blkdev_issue_discard " mchristi
2015-11-04 16:33 ` [Drbd-dev] [PATCH 05/32] drbd: prepare drbd " mchristi
2015-11-04 16:33 ` [Drbd-dev] [PATCH 06/32] xen blkback: prepare " mchristi
2015-11-04 16:33 ` [Drbd-dev] [PATCH 07/32] dm: " mchristi
2015-11-04 16:33 ` [Drbd-dev] [PATCH 08/32] target: " mchristi
2015-11-04 16:33 ` [Drbd-dev] [PATCH 09/32] btrfs: " mchristi
2015-11-04 16:49 ` [Drbd-dev] [dm-devel] [RFC PATCH 00/32] separate operations from flags in the bio/request structs Bart Van Assche
[not found] ` <563A3813.5010604@cs.wisc.edu>
2015-11-07 10:23 ` Christoph Hellwig [this message]
[not found] ` <5642F3F4.2060007@cs.wisc.edu>
2015-11-11 11:28 ` Christoph Hellwig
2015-11-11 17:37 ` [Drbd-dev] " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151107102309.GE12117@infradead.org \
--to=hch@infradead.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox