From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id B8504105643D for ; Tue, 29 Mar 2016 09:31:30 +0200 (CEST) Date: Tue, 29 Mar 2016 00:31:24 -0700 From: Christoph Hellwig To: Ming Lei Message-ID: <20160329073124.GH18920@infradead.org> References: <1458627149-12988-1-git-send-email-ming.lei@canonical.com> <1458627149-12988-8-git-send-email-ming.lei@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458627149-12988-8-git-send-email-ming.lei@canonical.com> Cc: Jens Axboe , Christoph Hellwig , Boaz Harrosh , Dave Chinner , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, linux-block@vger.kernel.org, Al Viro , Lars Ellenberg , Philipp Reisner , Anton Altaparmakov , drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 7/8] block: drbd: avoid to use BIO_MAX_SIZE List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Mar 22, 2016 at 02:12:28PM +0800, Ming Lei wrote: > drbd is the only user of BIO_MAX_SIZE, so use BIO_MAX_PAGES > instead. That whole code block looks completely bogus to me, although your patch doesn't make it any worse. I/O size for a network protocol shouldn't dependend on the number of vectors in a kernel internal structure. Well, getting rid of BIO_MAX_SIZE is worth it, so: Reviewed-by: Christoph Hellwig