From: Jan Kara <jack@suse.cz>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: dev@openvswitch.org, Jan Kara <jack@suse.cz>,
sd@queasysnail.net, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
jhs@mojatatu.com, pshelar@nicira.com, lars.ellenberg@linbit.com,
jack@suse.com, johannes@sipsolutions.net,
philipp.reisner@linbit.com, davem@davemloft.net,
kvalo@codeaurora.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit()
Date: Tue, 26 Apr 2016 14:37:07 +0200 [thread overview]
Message-ID: <20160426123707.GE27612@quack2.suse.cz> (raw)
In-Reply-To: <571F5FBE.8050900@6wind.com>
On Tue 26-04-16 14:31:58, Nicolas Dichtel wrote:
> Le 26/04/2016 13:08, Jan Kara a écrit :
> > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote:
> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> >
> > OK, so I somewhat miss a description of what will this do to the netlink
> > message so that I can judge whether the change is fine for the userspace
> > counterpart parsing these messages. AFAIU this changes the message format
> > by adding a QUOTA_NL_A_PAD field before each 64-bit field which needs an
> > alignment, am I guessing right? Thus when the userspace counterpart uses
> > genlmsg_parse() it should just silently ignore these attributes if I read
> > the documentation right. Did I understand this correctly?
> Yes, that's it.
OK, then feel free to add:
Acked-by: Jan Kara <jack@suse.cz>
to the quota patch.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2016-04-26 12:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 8:06 [Drbd-dev] [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] [PATCH net-next 1/8] macsec: use nla_put_u64_64bit() Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] [PATCH net-next 2/8] drivers/wireless: " Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] [PATCH net-next 3/8] fs/quota: " Nicolas Dichtel
2016-04-26 11:08 ` Jan Kara
2016-04-26 12:31 ` Nicolas Dichtel
2016-04-26 12:37 ` Jan Kara [this message]
2016-04-26 8:06 ` [Drbd-dev] [PATCH net-next 4/8] sock_diag: align nlattr properly when needed Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] [PATCH net-next 5/8] ovs: " Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] [PATCH net-next 6/8] rtnl: " Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] [PATCH net-next 7/8] neigh: " Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] [PATCH net-next 8/8] sched: " Nicolas Dichtel
2016-04-26 11:54 ` [Drbd-dev] [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Lars Ellenberg
2016-04-26 12:18 ` Lars Ellenberg
2016-05-03 8:50 ` [Drbd-dev] [PATCH net-next] block/drbd: use nla_put_u64_64bit() Nicolas Dichtel
2016-05-03 9:28 ` Nicolas Dichtel
2016-05-03 9:39 ` [Drbd-dev] [PATCH net-next v2] " Nicolas Dichtel
2016-05-03 10:06 ` Lars Ellenberg
2016-05-03 12:07 ` Nicolas Dichtel
2016-05-03 16:05 ` David Miller
2016-05-04 9:05 ` Lars Ellenberg
2016-05-04 12:49 ` Nicolas Dichtel
2016-05-04 12:52 ` Lars Ellenberg
2016-05-04 14:27 ` Eric Dumazet
2016-05-04 16:50 ` David Miller
2016-05-04 17:13 ` Eric Dumazet
2016-05-03 16:06 ` David Miller
2016-05-09 9:40 ` [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages Nicolas Dichtel
2016-05-09 13:15 ` Lars Ellenberg
2016-05-10 9:09 ` Nicolas Dichtel
2016-05-10 9:40 ` Lars Ellenberg
2016-05-10 10:06 ` Nicolas Dichtel
2016-05-10 15:39 ` David Miller
2016-05-10 19:09 ` Lars Ellenberg
2016-05-10 19:26 ` David Miller
2016-04-26 16:25 ` [Drbd-dev] [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426123707.GE27612@quack2.suse.cz \
--to=jack@suse.cz \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=drbd-dev@lists.linbit.com \
--cc=jack@suse.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=philipp.reisner@linbit.com \
--cc=pshelar@nicira.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox