From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTPS id ACE2A1056332 for ; Wed, 1 Jun 2016 15:44:32 +0200 (CEST) Date: Wed, 1 Jun 2016 06:44:27 -0700 From: Christoph Hellwig To: Ming Lei Message-ID: <20160601134427.GA15888@infradead.org> References: <1464615294-9946-1-git-send-email-ming.lei@canonical.com> <20160531155348.GA24840@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: linux-block@vger.kernel.org, Michal Hocko , Jan Kara , "Martin K. Petersen" , Mike Snitzer , Christoph Hellwig , Steven Whitehouse , Linux Kernel Mailing List , Sagi Grimberg , NeilBrown , Jens Axboe , Joe Thornber , Al Viro , Shaohua Li , Tejun Heo , Keith Busch , "open list:XFS FILESYSTEM" , Kent Overstreet , "Kirill A. Shutemov" , "open list:DRBD DRIVER" Subject: Re: [Drbd-dev] [PATCH v6 0/8] block: prepare for multipage bvecs List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 01, 2016 at 08:38:41PM +0800, Ming Lei wrote: > > be dm-crypt.c. Maybe you've identified some indirect use of > > BIO_MAX_SIZE? > > I mean the recently introduced BIO_MAX_SIZE in -next tree: > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/md/dm-crypt.c?id=4ed89c97b0706477b822ea2182827640c0cec486 The crazy bcache bios striking back once again. I really think it's harmful having a _MAX value and then having a minor driver reinterpreting it and sending larger ones. Until we can lift the maximum limit in general nad have common code exercise it we really need to stop bcache from sending these instead of littering the tree with workarounds.