From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org,
Philipp Reisner <philipp.reisner@linbit.com>,
Jens Axboe <axboe@fb.com>,
linux-fsdevel@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"open list:DRBD DRIVER" <drbd-dev@lists.linbit.com>
Subject: Re: [Drbd-dev] [PATCH 03/60] block: drbd: remove impossible failure handling
Date: Mon, 31 Oct 2016 08:25:49 -0700 [thread overview]
Message-ID: <20161031152549.GA30919@infradead.org> (raw)
In-Reply-To: <1477728600-12938-4-git-send-email-tom.leiming@gmail.com>
On Sat, Oct 29, 2016 at 04:08:02PM +0800, Ming Lei wrote:
> For a non-cloned bio, bio_add_page() only returns failure when
> the io vec table is full, but in that case, bio->bi_vcnt can't
> be zero at all.
>
> So remove the impossible failure handling.
>
> Acked-by: Lars Ellenberg <lars.ellenberg@linbit.com>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2016-10-31 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 8:07 [Drbd-dev] [PATCH 00/60] block: support multipage bvec Ming Lei
2016-10-29 8:08 ` [Drbd-dev] [PATCH 03/60] block: drbd: remove impossible failure handling Ming Lei
2016-10-31 15:25 ` Christoph Hellwig [this message]
2016-10-29 8:08 ` [Drbd-dev] [PATCH 14/60] block: drbd: comment on direct access bvec table Ming Lei
2016-10-31 15:25 ` [Drbd-dev] [PATCH 00/60] block: support multipage bvec Christoph Hellwig
2016-10-31 22:52 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031152549.GA30919@infradead.org \
--to=hch@infradead.org \
--cc=axboe@fb.com \
--cc=drbd-dev@lists.linbit.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox