From: Roland Kammerer <roland.kammerer@linbit.com>
To: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [Patch v0 5/8] Use refcount_t 'atomic' type to implement structref
Date: Thu, 9 Mar 2017 11:33:17 +0100 [thread overview]
Message-ID: <20170309103317.GC18615@rck.sh> (raw)
In-Reply-To: <1488857279-29079-6-git-send-email-nwang@suse.com>
On Tue, Mar 07, 2017 at 11:27:56AM +0800, Nick Wang wrote:
> diff --git a/drbd/drbd_req.c b/drbd/drbd_req.c
> index d6d9dc1..467549a 100644
> --- a/drbd/drbd_req.c
> +++ b/drbd/drbd_req.c
> @@ -124,7 +124,11 @@ void drbd_queue_peer_ack(struct drbd_resource *resource, struct drbd_request *re
> connection->cstate[NOW] != C_CONNECTED ||
> !(req->rq_state[1 + node_id] & RQ_NET_SENT))
> continue;
> +#ifdef COMPAT_HAVE_REFCOUNT_INC
> + refcount_inc(&req->kref.refcount); /* was 0, instead of kref_get() */
> +#else
> atomic_inc(&req->kref.refcount); /* was 0, instead of kref_get() */
> +#endif
We want to avoid #ifdef hell as much as possible in the code itself. In
that case use the new refcount_inc() and if it does not exist, fall back
to atomic_inc() via defining refcount_inc() to atomic_inc.
Regards, rck
next prev parent reply other threads:[~2017-03-09 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 3:27 [Drbd-dev] [Patch v0 0/8] Patches for compat drbd9 to kernel v4.10 Nick Wang
2017-03-07 3:27 ` [Drbd-dev] [Patch v0 1/8] Remove bio_set_op_attrs Nick Wang
2017-03-07 3:37 ` Nick Wang
2017-03-07 3:27 ` [Drbd-dev] [Patch v0 2/8] Adapt pointer backing_dev_info in struct request_queue Nick Wang
2017-03-09 10:27 ` Roland Kammerer
2017-03-07 3:27 ` [Drbd-dev] [Patch v0 3/8] " Nick Wang
2017-03-07 3:27 ` [Drbd-dev] [Patch v0 4/8] Use refcount_t 'atomic' type to implement struct kref Nick Wang
2017-03-07 3:27 ` [Drbd-dev] [Patch v0 5/8] Use refcount_t 'atomic' type to implement structref Nick Wang
2017-03-09 10:33 ` Roland Kammerer [this message]
2017-03-07 3:27 ` [Drbd-dev] [Patch v0 6/6] Statically initialize families Nick Wang
2017-03-07 3:27 ` [Drbd-dev] [Patch v0 7/8] " Nick Wang
2017-03-07 3:27 ` [Drbd-dev] [Patch v0 8/8] " Nick Wang
2017-03-09 9:21 ` [Drbd-dev] [Patch v0 0/8] Patches for compat drbd9 to kernel v4.10 Lars Ellenberg
2017-03-09 10:22 ` Roland Kammerer
2017-03-10 3:48 ` Nick Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309103317.GC18615@rck.sh \
--to=roland.kammerer@linbit.com \
--cc=drbd-dev@lists.linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox