From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 930FE1056332 for ; Tue, 2 May 2017 09:23:29 +0200 (CEST) Date: Tue, 2 May 2017 09:23:28 +0200 From: "hch@lst.de" To: "Nicholas A. Bellinger" Message-ID: <20170502072328.GA11522@lst.de> References: <20170405172125.22600-1-hch@lst.de> <20170405172125.22600-26-hch@lst.de> <1493671519.2665.15.camel@sandisk.com> <1493707425.23202.77.camel@haakon3.risingtidesystems.com> <1493709373.23202.79.camel@haakon3.risingtidesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493709373.23202.79.camel@haakon3.risingtidesystems.com> Cc: "axboe@kernel.dk" , "linux-raid@vger.kernel.org" , "snitzer@redhat.com" , "martin.petersen@oracle.com" , "philipp.reisner@linbit.com" , "linux-block@vger.kernel.org" , "dm-devel@redhat.com" , "target-devel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Bart Van Assche , "lars.ellenberg@linbit.com" , "shli@kernel.org" , "hch@lst.de" , "agk@redhat.com" , "drbd-dev@lists.linbit.com" Subject: Re: [Drbd-dev] [PATCH 25/27] block: remove the discard_zeroes_data flag List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, May 02, 2017 at 12:16:13AM -0700, Nicholas A. Bellinger wrote: > Or, another options is use bdev_write_zeroes_sectors() to determine when > dev_attrib->unmap_zeroes_data should be set. Yes, that in combination with your patch to use bdev_write_zeroes_sectors for zeroing from write same seems like the right fix.