Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Roland Kammerer <roland.kammerer@linbit.com>
To: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: Allow to override build date (v2)
Date: Tue, 18 Jul 2017 16:45:51 +0200	[thread overview]
Message-ID: <20170718144551.GE1453@rck.sh> (raw)
In-Reply-To: <ce35732f-d0c4-cd8d-66f9-e5785d0bdbe2@suse.de>

On Tue, Jul 18, 2017 at 02:47:54PM +0200, Bernhard M. Wiedemann wrote:
> 
> > No. What if setting SOURCE_DATE_EPOCH becomes the default in the future?
> > Maybe it already is for some of the distributions we as LINBIT build
> > packages for. Sorry for being the spoilsport here, but as it stands I
> > only see the potential of breaking the way we want it .
> 
> It already _is_ the default for openSUSE Tumbleweed (aka Factory)...

See, then it was good not taking it as it was, as it would have changed
the behavior from what *we intentionally* want to what *you* want.

> If you are that reliant/insistent on this date, we could add another

I'm insistent on one simple thing: Don't break our existing code/builds
with something you want.

> [ -z "${WANT_DRBD_REPRODUCIBLE_BUILD}" ] ||

Looks good, merged your v3 patch.

Thanks, rck

  parent reply	other threads:[~2017-07-18 14:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18  8:35 [Drbd-dev] [PATCH] drbd: Allow to override build date Bernhard M. Wiedemann
2017-07-18  9:13 ` [Drbd-dev] [PATCH] drbd: Allow to override build date (v2) Bernhard M. Wiedemann
2017-07-18 12:35   ` Roland Kammerer
2017-07-18 12:47     ` Bernhard M. Wiedemann
2017-07-18 12:48       ` [Drbd-dev] [PATCH] drbd: Allow to override build date (v3) Bernhard M. Wiedemann
2017-07-23 15:57         ` [Drbd-dev] [PATCH] drbd-utils: Allow to override build date Bernhard M. Wiedemann
2017-07-24  5:16           ` Roland Kammerer
2017-07-18 14:45       ` Roland Kammerer [this message]
2017-07-18 14:59         ` [Drbd-dev] [PATCH] drbd: Allow to override build date (v2) Bernhard M. Wiedemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718144551.GE1453@rck.sh \
    --to=roland.kammerer@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox