From: Roland Kammerer <roland.kammerer@linbit.com>
To: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] Potentially invalid memory accesses in file drivers/block/drbd/drbd_worker.c
Date: Thu, 20 Jul 2017 14:10:31 +0200 [thread overview]
Message-ID: <20170720121030.GT1453@rck.sh> (raw)
In-Reply-To: <6863677bb21b5adb672d850983d5f8d1@cs.utah.edu>
On Wed, Jul 19, 2017 at 10:50:47PM -0600, Shaobo wrote:
> Hi there,
>
> My name is Shaobo He and I am a graduate student at University of Utah. I am
> using a static analysis tool to search for null pointer dereferences and
> came across a couple of potentially invalid memory accesses in the file
> drivers/block/drbd/drbd_worker.c: in function `drbd_start_resync`, pointer
> variable `connection` in line 1727 can be NULL while is dereferenced at line
> 1767 (```if (current == connection->worker.task) {```).
>
> Please let me know if it makes sense. I am looking forward to your reply.
Hi Shaobo,
While highly theoretical and unlikely, better be safe than sorry. Fixed
and we will send that to mainline Linux soon.
Regards, rck
prev parent reply other threads:[~2017-07-20 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 4:50 [Drbd-dev] Potentially invalid memory accesses in file drivers/block/drbd/drbd_worker.c Shaobo
2017-07-20 12:10 ` Roland Kammerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720121030.GT1453@rck.sh \
--to=roland.kammerer@linbit.com \
--cc=drbd-dev@lists.linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox