From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-mmc@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH 04/16] block: use atomic bitops for ->queue_flags
Date: Thu, 15 Nov 2018 10:04:35 +0100 [thread overview]
Message-ID: <20181115090435.GA14370@lst.de> (raw)
In-Reply-To: <ddb96188-b2dd-6aaf-90f5-7eb5889691f8@suse.de>
On Thu, Nov 15, 2018 at 07:55:02AM +0100, Hannes Reinecke wrote:
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> ---
>> block/blk-core.c | 54 ++++++----------------------------------
>> block/blk-mq.c | 2 +-
>> block/blk-settings.c | 10 +++-----
>> block/blk-sysfs.c | 28 +++++++++------------
>> block/blk.h | 56 ------------------------------------------
>> include/linux/blkdev.h | 1 -
>> 6 files changed, 24 insertions(+), 127 deletions(-)
>>
> I wonder if we can't remove the 'blk_queue_flag_XXX' helpers and replace
> them with inlines ...
I'd prefer to just open code the *bit helpers as that is a lot more
reasonable. But that is quite a lot of churn, so I'll only do that if
I get previous buy-in to that idea, and preferably in a separate series.
next prev parent reply other threads:[~2018-11-15 9:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 16:02 [Drbd-dev] remove more legacy request leftover Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 01/16] block: remove QUEUE_FLAG_BYPASS and ->bypass Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 02/16] block: remove deadline __deadline manipulation helpers Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 03/16] block: don't hold the queue_lock over blk_abort_request Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 04/16] block: use atomic bitops for ->queue_flags Christoph Hellwig
[not found] ` <ddb96188-b2dd-6aaf-90f5-7eb5889691f8@suse.de>
2018-11-15 9:04 ` Christoph Hellwig [this message]
2018-11-14 16:02 ` [Drbd-dev] [PATCH 05/16] block: remove queue_lockdep_assert_held Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 06/16] block-iolatency: remove the unused lock argument to rq_qos_throttle Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 07/16] block: update a few comments for the legacy request removal Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 08/16] block: remove a few unused exports Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 09/16] blk-cgroup: consolidate error handling in blkcg_init_queue Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 10/16] blk-cgroup: move locking into blkg_destroy_all Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 11/16] drbd: don't override the queue_lock Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 12/16] umem: " Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 13/16] mmc: simplify queue initialization Christoph Hellwig
[not found] ` <CAPDyKFqq=MiiM7h_GGb3S=+TSD=LayLTefigovuPJAsqMJgOEg@mail.gmail.com>
2018-11-15 9:02 ` Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 14/16] mmc: stop abusing the request queue_lock pointer Christoph Hellwig
[not found] ` <CAPDyKFrEWQdOKHu2FeyzPvLCDrRa+QouG6OjEzf=JF1yxoTRgw@mail.gmail.com>
2018-11-15 9:03 ` Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 15/16] block: remove the lock argument to blk_alloc_queue_node Christoph Hellwig
2018-11-14 16:02 ` [Drbd-dev] [PATCH 16/16] block: remove the queue_lock indirection Christoph Hellwig
2018-11-15 19:14 ` [Drbd-dev] remove more legacy request leftover Jens Axboe
2018-11-15 19:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115090435.GA14370@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox