From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 177AE4203F4 for ; Sat, 13 Jun 2020 11:56:31 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id e1so12304106wrt.5 for ; Sat, 13 Jun 2020 02:56:31 -0700 (PDT) Received: from soda.linbit (62-99-137-214.static.upcbusiness.at. [62.99.137.214]) by smtp.gmail.com with ESMTPSA id u9sm13365604wme.16.2020.06.13.02.56.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Jun 2020 02:56:30 -0700 (PDT) Resent-Message-ID: <20200613095628.GH4222@soda.linbit> Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 7CEFA4202F0 for ; Wed, 13 May 2020 14:52:46 +0200 (CEST) Received: by mail-qk1-f195.google.com with SMTP id i5so915559qkl.12 for ; Wed, 13 May 2020 05:52:46 -0700 (PDT) From: Jason Gunthorpe To: Christoph Hellwig Message-ID: <20200513125144.GC29989@ziepe.ca> References: <20200513062649.2100053-1-hch@lst.de> <20200513062649.2100053-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513062649.2100053-12-hch@lst.de> Cc: Marcelo Ricardo Leitner , Eric Dumazet , linux-nvme@lists.infradead.org, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, Alexey Kuznetsov , linux-block@vger.kernel.org, Jakub Kicinski , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Neil Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, Vlad Yasevich , linux-kernel@vger.kernel.org, Jon Maloy , Ying Xue , "David S. Miller" , ocfs2-devel@oss.oracle.com Subject: Re: [Drbd-dev] [PATCH 11/33] tcp: tcp_sock_set_nodelay List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sat, 13 Jun 2020 09:58:45 -0000 On Wed, May 13, 2020 at 08:26:26AM +0200, Christoph Hellwig wrote: > Add a helper to directly set the TCP_NODELAY sockopt from kernel space > without going through a fake uaccess. Cleanup the callers to avoid > pointless wrappers now that this is a simple function call. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/drbd/drbd_int.h | 7 ---- > drivers/block/drbd/drbd_main.c | 2 +- > drivers/block/drbd/drbd_receiver.c | 4 +-- > drivers/infiniband/sw/siw/siw_cm.c | 24 +++----------- > drivers/nvme/host/tcp.c | 9 +----- > drivers/nvme/target/tcp.c | 12 ++----- > drivers/target/iscsi/iscsi_target_login.c | 15 ++------- > fs/cifs/connect.c | 10 ++---- > fs/dlm/lowcomms.c | 8 ++--- > fs/ocfs2/cluster/tcp.c | 20 ++---------- > include/linux/tcp.h | 1 + > net/ceph/messenger.c | 11 ++----- > net/ipv4/tcp.c | 39 +++++++++++++++-------- > net/rds/tcp.c | 11 +------ > net/rds/tcp.h | 1 - > net/rds/tcp_listen.c | 2 +- > 16 files changed, 49 insertions(+), 127 deletions(-) No problem with the siw change Acked-by: Jason Gunthorpe Jason