From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 8BA3E42030B for ; Thu, 4 Jun 2020 03:40:12 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id h95so387739pje.4 for ; Wed, 03 Jun 2020 18:40:12 -0700 (PDT) Date: Wed, 3 Jun 2020 18:40:09 -0700 From: Kees Cook To: Joe Perches Message-ID: <202006031838.55722640DC@keescook> References: <20200603233203.1695403-1-keescook@chromium.org> <20200603233203.1695403-9-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: clang-built-linux@googlegroups.com, linux-ide@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-block@vger.kernel.org, Miguel Ojeda , linux-mm@kvack.org, Alexander Potapenko , b43-dev@lists.infradead.org, Andy Whitcroft , Linus Torvalds , linux-clk@vger.kernel.org, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 08/10] checkpatch: Remove awareness of uninitialized_var() macro List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jun 03, 2020 at 05:02:29PM -0700, Joe Perches wrote: > On Wed, 2020-06-03 at 16:32 -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings > > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > > either simply initialize the variable or make compiler changes. > > > > In preparation for removing[2] the[3] macro[4], effectively revert > > commit 16b7f3c89907 ("checkpatch: avoid warning about uninitialized_var()") > > and remove all remaining mentions of uninitialized_var(). > > > > [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/ > > [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ > > [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ > > [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ > > nack. see below. > > I'd prefer a simple revert, but it shouldn't > be done here. What do you mean? (I can't understand this and "fine by me" below?) > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > @@ -4075,7 +4074,7 @@ sub process { > > } > > > > # check for function declarations without arguments like "int foo()" > > - if ($line =~ /(\b$Type\s*$Ident)\s*\(\s*\)/) { > > + if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) { > > This isn't right because $Type includes a possible trailing * > where there isn't a space between $Type and $Ident Ah, hm, that was changed in the mentioned commit: - if ($line =~ /(\b$Type\s+$Ident)\s*\(\s*\)/) { + if ($line =~ /(\b$Type\s*$Ident)\s*\(\s*\)/) { > > e.g.: int *bar(void); > > Other than that, fine by me... Thanks for looking it over! I'll adjust it however you'd like. :) -- Kees Cook