From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 070F24203B3 for ; Thu, 4 Jun 2020 16:59:47 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id d10so3580005pgn.4 for ; Thu, 04 Jun 2020 07:59:47 -0700 (PDT) Date: Thu, 4 Jun 2020 07:59:40 -0700 From: Kees Cook To: Jason Gunthorpe Message-ID: <202006040757.0DFC3F28E@keescook> References: <20200603233203.1695403-1-keescook@chromium.org> <20200603233203.1695403-10-keescook@chromium.org> <20200604132306.GO6578@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200604132306.GO6578@ziepe.ca> Cc: Andy Whitcroft , clang-built-linux@googlegroups.com, linux-ide@vger.kernel.org, netdev@vger.kernel.org, x86@kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-block@vger.kernel.org, Miguel Ojeda , linux-mm@kvack.org, Alexander Potapenko , b43-dev@lists.infradead.org, Joe Perches , Linus Torvalds , linux-clk@vger.kernel.org, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 09/10] treewide: Remove uninitialized_var() usage List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jun 04, 2020 at 10:23:06AM -0300, Jason Gunthorpe wrote: > On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings > > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > > either simply initialize the variable or make compiler changes. > > > > I preparation for removing[2] the[3] macro[4], remove all remaining > > needless uses with the following script: > > > > git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \ > > xargs perl -pi -e \ > > 's/\buninitialized_var\(([^\)]+)\)/\1/g; > > s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;' > > > > drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid > > pathological white-space. > > > > No outstanding warnings were found building allmodconfig with GCC 9.3.0 > > for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64, > > alpha, and m68k. > > At least in the infiniband part I'm confident that old gcc versions > will print warnings after this patch. > > As the warnings are wrong, do we care? Should old gcc maybe just -Wno- > the warning? I *think* a lot of those are from -Wmaybe-uninitialized, but Linus just turned that off unconditionally in v5.7: 78a5255ffb6a ("Stop the ad-hoc games with -Wno-maybe-initialized") I'll try to double-check with some older gcc versions. My compiler collection is mostly single-axis: lots of arches, not lots of versions. ;) > Otherwise the IB bits look ok to me > > Acked-by: Jason Gunthorpe Thanks! -- Kees Cook