From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 56A44420DE3 for ; Thu, 17 Sep 2020 12:05:00 +0200 (CEST) Date: Thu, 17 Sep 2020 12:04:59 +0200 From: Jan Kara To: Christoph Hellwig Message-ID: <20200917100459.GK7347@quack2.suse.cz> References: <20200910144833.742260-1-hch@lst.de> <20200910144833.742260-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200910144833.742260-5-hch@lst.de> Cc: Jens Axboe , linux-raid@vger.kernel.org, Hans de Goede , Minchan Kim , Richard Weinberger , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Song Liu , dm-devel@redhat.com, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, David Sterba , linux-mm@kvack.org, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH 04/12] bdi: initialize ->ra_pages and ->io_pages in bdi_init List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu 10-09-20 16:48:24, Christoph Hellwig wrote: > Set up a readahead size by default, as very few users have a good > reason to change it. > > Signed-off-by: Christoph Hellwig > Acked-by: David Sterba [btrfs] > Acked-by: Richard Weinberger [ubifs, mtd] Looks good but what about coda, ecryptfs, and orangefs? Currenly they have readahead disabled and this patch would seem to enable it? > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index 8e8b00627bb2d8..2dac3be6127127 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -746,6 +746,8 @@ struct backing_dev_info *bdi_alloc(int node_id) > kfree(bdi); > return NULL; > } > + bdi->ra_pages = VM_READAHEAD_PAGES; > + bdi->io_pages = VM_READAHEAD_PAGES; Won't this be more logical in bdi_init() than in bdi_alloc()? Honza -- Jan Kara SUSE Labs, CR