From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id C27A8420377 for ; Thu, 26 Nov 2020 02:16:22 +0100 (CET) Received: by mail-pf1-f195.google.com with SMTP id 131so111193pfb.9 for ; Wed, 25 Nov 2020 17:16:22 -0800 (PST) Sender: Minchan Kim Date: Wed, 25 Nov 2020 17:16:16 -0800 From: Minchan Kim To: Christoph Hellwig Message-ID: <20201126011616.GB57352@google.com> References: <20201116145809.410558-1-hch@lst.de> <20201116145809.410558-62-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116145809.410558-62-hch@lst.de> Cc: Justin Sanders , sergey.senozhatsky.work@gmail.com, Mike Snitzer , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, Ilya Dryomov , Jack Wang , Konrad Rzeszutek Wilk , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, Stefan Hajnoczi , ceph-devel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [Drbd-dev] [PATCH 61/78] zram: do not call set_blocksize List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Nov 16, 2020 at 03:57:52PM +0100, Christoph Hellwig wrote: > set_blocksize is used by file systems to use their preferred buffer cache > block size. Block drivers should not set it. > > Signed-off-by: Christoph Hellwig Acked-by: Minchan Kim Thanks. > --- > drivers/block/zram/zram_drv.c | 11 +---------- > drivers/block/zram/zram_drv.h | 1 - > 2 files changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index 3641434a9b154d..d00b5761ec0b21 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -403,13 +403,10 @@ static void reset_bdev(struct zram *zram) > return; > > bdev = zram->bdev; > - if (zram->old_block_size) > - set_blocksize(bdev, zram->old_block_size); > blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL); > /* hope filp_close flush all of IO */ > filp_close(zram->backing_dev, NULL); > zram->backing_dev = NULL; > - zram->old_block_size = 0; > zram->bdev = NULL; > zram->disk->fops = &zram_devops; > kvfree(zram->bitmap); > @@ -454,7 +451,7 @@ static ssize_t backing_dev_store(struct device *dev, > struct file *backing_dev = NULL; > struct inode *inode; > struct address_space *mapping; > - unsigned int bitmap_sz, old_block_size = 0; > + unsigned int bitmap_sz; > unsigned long nr_pages, *bitmap = NULL; > struct block_device *bdev = NULL; > int err; > @@ -509,14 +506,8 @@ static ssize_t backing_dev_store(struct device *dev, > goto out; > } > > - old_block_size = block_size(bdev); > - err = set_blocksize(bdev, PAGE_SIZE); > - if (err) > - goto out; > - > reset_bdev(zram); > > - zram->old_block_size = old_block_size; > zram->bdev = bdev; > zram->backing_dev = backing_dev; > zram->bitmap = bitmap; > diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h > index f2fd46daa76045..712354a4207c77 100644 > --- a/drivers/block/zram/zram_drv.h > +++ b/drivers/block/zram/zram_drv.h > @@ -118,7 +118,6 @@ struct zram { > bool wb_limit_enable; > u64 bd_wb_limit; > struct block_device *bdev; > - unsigned int old_block_size; > unsigned long *bitmap; > unsigned long nr_pages; > #endif > -- > 2.29.2 >