Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Michael D Labriola <michael.d.labriola@gmail.com>
To: drbd-dev@lists.linbit.com
Subject: [Drbd-dev] [PATCH 6/8] drbd: get rid of set_fs() usage
Date: Sun, 13 Dec 2020 00:07:02 -0500	[thread overview]
Message-ID: <20201213050704.997-7-michael.d.labriola@gmail.com> (raw)
In-Reply-To: <20201213050704.997-1-michael.d.labriola@gmail.com>

5.10 is getting rid of set_fs().  When I went looking through git commits
to figure out how to properly protect sendpage, what I found was this
commit from 4.13:

    10428957 drbd: ->sendpage() never needed set_fs()

Signed-off-by: Michael D Labriola <michael.d.labriola@gmail.com>
---
 drbd/drbd_transport_tcp.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drbd/drbd_transport_tcp.c b/drbd/drbd_transport_tcp.c
index 3b1d4273..4e076460 100644
--- a/drbd/drbd_transport_tcp.c
+++ b/drbd/drbd_transport_tcp.c
@@ -1138,7 +1138,6 @@ static int dtt_send_page(struct drbd_transport *transport, enum drbd_stream stre
 	struct drbd_tcp_transport *tcp_transport =
 		container_of(transport, struct drbd_tcp_transport, transport);
 	struct socket *socket = tcp_transport->stream[stream];
-	mm_segment_t oldfs = get_fs();
 	int len = size;
 	int err = -EIO;
 
@@ -1147,7 +1146,6 @@ static int dtt_send_page(struct drbd_transport *transport, enum drbd_stream stre
 
 	msg_flags |= MSG_NOSIGNAL;
 	dtt_update_congested(tcp_transport);
-	set_fs(KERNEL_DS);
 	do {
 		int sent;
 
@@ -1173,7 +1171,6 @@ static int dtt_send_page(struct drbd_transport *transport, enum drbd_stream stre
 		 * and add that to the while() condition below.
 		 */
 	} while (len > 0 /* THINK && peer_device->repl_state[NOW] >= L_ESTABLISHED */);
-	set_fs(oldfs);
 	clear_bit(NET_CONGESTED, &tcp_transport->transport.flags);
 
 	if (len == 0)
-- 
2.17.1


  parent reply	other threads:[~2020-12-13  5:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-13  5:06 [Drbd-dev] Get drbd-9.0 branch building with Linux 5.9 and 5.10 Michael D Labriola
2020-12-13  5:06 ` [Drbd-dev] [PATCH 1/8] compat: fix include for submit_bio test Michael D Labriola
2020-12-13  5:06 ` [Drbd-dev] [PATCH 2/8] compat: fix include for blkdev_get_by_path test Michael D Labriola
2020-12-13  5:06 ` [Drbd-dev] [PATCH 3/8] drbd: don't include vermagic.h Michael D Labriola
2020-12-13  5:07 ` [Drbd-dev] [PATCH 4/8] drbd: fix drbd_submit_bio argument handling Michael D Labriola
2020-12-13  5:07 ` [Drbd-dev] [PATCH 5/8] drbd: use sock_set_keepalive() instead of kernel_setsockopt() Michael D Labriola
2020-12-13  5:07 ` Michael D Labriola [this message]
2020-12-13  5:07 ` [Drbd-dev] [PATCH 7/8] drbd: don't use sched_setscheduler() Michael D Labriola
2020-12-13  5:07 ` [Drbd-dev] [PATCH 8/8] compat: remove set_bdi_cap_stable_writes Michael D Labriola
  -- strict thread matches above, loose matches on Subject: below --
2020-12-13  5:58 [Drbd-dev] Get drbd-9.0 branch building with Linux 5.9 and 5.10 Michael D Labriola
2020-12-13  5:58 ` [Drbd-dev] [PATCH 6/8] drbd: get rid of set_fs() usage Michael D Labriola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201213050704.997-7-michael.d.labriola@gmail.com \
    --to=michael.d.labriola@gmail.com \
    --cc=drbd-dev@lists.linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox