From: Rui Xu <rui.xu@easystack.cn>
To: philipp.reisner@linbit.com, drbd-dev@lists.linbit.com,
joel.colledge@linbit.com
Cc: Rui Xu <rui.xu@easystack.cn>, dongsheng.yang@easystack.cn
Subject: [Drbd-dev] [PATCH] drbd: fix a bug with two-primaries configuration
Date: Thu, 28 Jul 2022 19:47:59 +0800 [thread overview]
Message-ID: <20220728114759.810371-1-rui.xu@easystack.cn> (raw)
There is a bug when execute 'drbdsetup disconnect' in
two-primaries configuration.
When 'drbdsetup disconnect' is called by user, two primary
nodes will going to outdated in do_change_cstate, then the
command will failed since there is no UpToDate node.
Fix it by modify the judgment condition in do_change_cstate.
Signed-off-by: Rui Xu <rui.xu@easystack.cn>
---
drbd/drbd_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drbd/drbd_state.c b/drbd/drbd_state.c
index 792a96d5..c4f3f776 100644
--- a/drbd/drbd_state.c
+++ b/drbd/drbd_state.c
@@ -5406,7 +5406,7 @@ static bool do_change_cstate(struct change_context *context, enum change_phase p
u64 directly_reachable = directly_connected_nodes(resource, NEW) |
NODE_MASK(resource->res_opts.node_id);
- if (reply->primary_nodes & ~directly_reachable)
+ if (!(reply->primary_nodes & directly_reachable))
__outdate_myself(resource);
}
--
2.25.1
next reply other threads:[~2022-07-28 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 11:47 Rui Xu [this message]
2022-08-01 14:22 ` [Drbd-dev] [PATCH] drbd: fix a bug with two-primaries configuration Joel Colledge
2022-08-02 2:35 ` rui.xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728114759.810371-1-rui.xu@easystack.cn \
--to=rui.xu@easystack.cn \
--cc=dongsheng.yang@easystack.cn \
--cc=drbd-dev@lists.linbit.com \
--cc=joel.colledge@linbit.com \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox