From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 4F8784201A5 for ; Wed, 5 Oct 2022 07:19:10 +0200 (CEST) From: Chaitanya Kulkarni To: , , , , , , Date: Tue, 4 Oct 2022 22:00:26 -0700 Message-ID: <20221005050027.39591-18-kch@nvidia.com> In-Reply-To: <20221005050027.39591-1-kch@nvidia.com> References: <20221005050027.39591-1-kch@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Cc: axboe@kernel.dk, vincent.fu@samsung.com, ming.lei@redhat.com, kch@nvidia.com, vigneshr@ti.com, richard@nod.at, damien.lemoal@opensource.wdc.com, philipp.reisner@linbit.com, efremov@linux.com, josef@toxicpanda.com, mcgrof@kernel.org, haris.iqbal@ionos.com, hare@suse.de, miquel.raynal@bootlin.com, shinichiro.kawasaki@wdc.com, lars.ellenberg@linbit.com, johannes.thumshirn@wdc.com, jinpu.wang@ionos.com, tim@cyberelk.net, bvanassche@acm.org Subject: [Drbd-dev] [RFC PATCH 17/18] z2ram: use init disk helper List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Add and use the helper to initialize the common fields of struct gendisk such as major, first_minor, minors, disk_name, private_data, and ops. This initialization is spread all over the block drivers. This avoids code repetation of inialization code of gendisk in current block drivers and any future ones. Signed-off-by: Chaitanya Kulkarni --- drivers/block/z2ram.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index c1e85f356e4d..74432fbfe42c 100644 --- a/drivers/block/z2ram.c +++ b/drivers/block/z2ram.c @@ -324,11 +324,8 @@ static int z2ram_register_disk(int minor) if (IS_ERR(disk)) return PTR_ERR(disk); - disk->major = Z2RAM_MAJOR; - disk->first_minor = minor; - disk->minors = 1; disk->flags |= GENHD_FL_NO_PART; - disk->fops = &z2_fops; + init_disk(disk, Z2RAM_MAJOR, minor, 1, 0, NULL, &z2_fops); if (minor) sprintf(disk->disk_name, "z2ram%d", minor); else -- 2.29.0