From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Philipp Reisner <philipp.reisner@linbit.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com
Subject: [Drbd-dev] [PATCH 2/4] lru_cache: remove compiled out code
Date: Tue, 22 Nov 2022 14:42:59 +0100 [thread overview]
Message-ID: <20221122134301.69258-3-christoph.boehmwalder@linbit.com> (raw)
In-Reply-To: <20221122134301.69258-1-christoph.boehmwalder@linbit.com>
Signed-off-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
---
lib/lru_cache.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/lib/lru_cache.c b/lib/lru_cache.c
index fec899386238..5dd5e4c00a23 100644
--- a/lib/lru_cache.c
+++ b/lib/lru_cache.c
@@ -60,17 +60,6 @@ int lc_try_lock(struct lru_cache *lc)
} while (unlikely (val == LC_PARANOIA));
/* Spin until no-one is inside a PARANOIA_ENTRY()/RETURN() section. */
return 0 == val;
-#if 0
- /* Alternative approach, spin in case someone enters or leaves a
- * PARANOIA_ENTRY()/RETURN() section. */
- unsigned long old, new, val;
- do {
- old = lc->flags & LC_PARANOIA;
- new = old | LC_LOCKED;
- val = cmpxchg(&lc->flags, old, new);
- } while (unlikely (val == (old ^ LC_PARANOIA)));
- return old == val;
-#endif
}
/**
--
2.38.1
next prev parent reply other threads:[~2022-11-22 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 13:42 [Drbd-dev] [PATCH 0/4] lru_cache improvements, DRBD license identifiers Christoph Böhmwalder
2022-11-22 13:42 ` [Drbd-dev] [PATCH 1/4] lru_cache: use atomic operations when accessing lc->flags, always Christoph Böhmwalder
2022-11-22 13:42 ` Christoph Böhmwalder [this message]
2022-11-22 13:43 ` [Drbd-dev] [PATCH 3/4] lru_cache: remove unused lc_private, lc_set, lc_index_of Christoph Böhmwalder
2022-11-22 13:43 ` [Drbd-dev] [PATCH 4/4] drbd: use consistent license Christoph Böhmwalder
2022-11-23 2:39 ` [Drbd-dev] [PATCH 0/4] lru_cache improvements, DRBD license identifiers Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122134301.69258-3-christoph.boehmwalder@linbit.com \
--to=christoph.boehmwalder@linbit.com \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox