From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 55C4942096A for ; Wed, 30 Nov 2022 13:07:39 +0100 (CET) Received: by mail-wr1-f69.google.com with SMTP id w11-20020adfbacb000000b002418a90da01so3490645wrg.16 for ; Wed, 30 Nov 2022 04:07:37 -0800 (PST) Date: Wed, 30 Nov 2022 13:07:32 +0100 From: Guillaume Nault To: Benjamin Coddington Message-ID: <20221130120732.GB29316@pc-4.home> References: <20221129140242.GA15747@lst.de> <794DBAB0-EDAF-4DA2-A837-C1F99916BC8E@redhat.com> MIME-Version: 1.0 In-Reply-To: <794DBAB0-EDAF-4DA2-A837-C1F99916BC8E@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Cc: Latchesar Ionkov , samba-technical@lists.samba.org, Dominique Martinet , Valentina Manea , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, David Howells , Joseph Qi , Eric Dumazet , linux-nfs@vger.kernel.org, Marc Dionne , Shuah Khan , Christoph Hellwig , Mike Christie , drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, Sagi Grimberg , linux-scsi@vger.kernel.org, Mark Fasheh , linux-afs@lists.infradead.org, cluster-devel@redhat.com, Christine Caulfield , Jakub Kicinski , Ilya Dryomov , Paolo Abeni , Anna Schumaker , Eric Van Hensbergen , "James E.J. Bottomley" , Josef Bacik , nbd@other.debian.org, linux-block@vger.kernel.org, David Teigland , Joel Becker , v9fs-developer@lists.sourceforge.net, Keith Busch , ceph-devel@vger.kernel.org, Xiubo Li , Trond Myklebust , Jens Axboe , Chris Leech , open-iscsi@googlegroups.com, "Martin K. Petersen" , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Jeff Layton , Philipp Reisner , Steve French , Chuck Lever , Lee Duncan , Greg Kroah-Hartman , Lars Ellenberg , "David S. Miller" , ocfs2-devel@oss.oracle.com Subject: Re: [Drbd-dev] [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Nov 29, 2022 at 11:47:47AM -0500, Benjamin Coddington wrote: > On 29 Nov 2022, at 9:02, Christoph Hellwig wrote: > > > Hmm. Having to set a flag to not accidentally corrupt per-task > > state seems a bit fragile. Wouldn't it make sense to find a way to opt > > into the feature only for sockets created from the syscall layer? > > It's totally fragile, and that's why it's currently broken in production. > The fragile ship sailed when networking decided to depend on users setting > the socket's GFP_ flags correctly to avoid corruption. > > Meantime, this problem needs fixing in a way that makes everyone happy. > This fix doesn't make it less fragile, but it may (hopefully) address the > previous criticisms enough that something gets done to fix it. Also, let's remember that while we're discussing how the kernel sould work in an ideal world, the reality is that production NFS systems crash randomly upon memory reclaim since commit a1231fda7e94 ("SUNRPC: Set memalloc_nofs_save() on all rpciod/xprtiod jobs"). Fixing that is just a matter of re-introducing GFP_NOFS on SUNRPC sockets (which has been proposed several times already). Then we'll have plenty of time to argue about how networking should use the per-task page_frag and how to remove GFP_NOFS in the long term.