From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Philipp Reisner <philipp.reisner@linbit.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com
Subject: [Drbd-dev] [PATCH 2/8] drbd: fix DRBD_VOLUME_MAX 65535 -> 65534
Date: Fri, 9 Dec 2022 15:53:21 +0100 [thread overview]
Message-ID: <20221209145327.2272271-3-christoph.boehmwalder@linbit.com> (raw)
In-Reply-To: <20221209145327.2272271-1-christoph.boehmwalder@linbit.com>
From: Robert Altnoeder <robert.altnoeder@linbit.com>
The protocol uses -1 as a reserved value for
'no specific volume', and since the protocol field
is a 16 bit unsigned value, -1 is converted to
65535. Therefore, limit the range of valid volume
numbers to [0, 65534].
Signed-off-by: Robert Altnoeder <robert.altnoeder@linbit.com>
Signed-off-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
Reviewed-by: Joel Colledge <joel.colledge@linbit.com>
---
include/linux/drbd_limits.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/drbd_limits.h b/include/linux/drbd_limits.h
index d64271ccece4..058f7600f79c 100644
--- a/include/linux/drbd_limits.h
+++ b/include/linux/drbd_limits.h
@@ -21,7 +21,7 @@
#define DRBD_MINOR_COUNT_DEF 32
#define DRBD_MINOR_COUNT_SCALE '1'
-#define DRBD_VOLUME_MAX 65535
+#define DRBD_VOLUME_MAX 65534
#define DRBD_DIALOG_REFRESH_MIN 0
#define DRBD_DIALOG_REFRESH_MAX 600
--
2.38.1
next prev parent reply other threads:[~2022-12-09 14:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 14:53 [Drbd-dev] [PATCH 0/8] Miscellaneous DRBD reorganization Christoph Böhmwalder
2022-12-09 14:53 ` [Drbd-dev] [PATCH 1/8] drbd: adjust drbd_limits license header Christoph Böhmwalder
2022-12-09 14:53 ` Christoph Böhmwalder [this message]
2022-12-09 14:53 ` [Drbd-dev] [PATCH 3/8] drbd: make limits unsigned Christoph Böhmwalder
2022-12-09 14:53 ` [Drbd-dev] [PATCH 4/8] drbd: remove unnecessary assignment in vli_encode_bits Christoph Böhmwalder
2022-12-09 14:53 ` [Drbd-dev] [PATCH 5/8] drbd: remove macros using require_context Christoph Böhmwalder
2022-12-09 14:53 ` [Drbd-dev] [PATCH 6/8] MAINTAINERS: add drbd headers Christoph Böhmwalder
2022-12-09 14:53 ` [Drbd-dev] [PATCH 7/8] drbd: interval tree: make removing an "empty" interval a no-op Christoph Böhmwalder
2022-12-09 14:53 ` [Drbd-dev] [PATCH 8/8] drbd: drbd_insert_interval(): Clarify comment Christoph Böhmwalder
-- strict thread matches above, loose matches on Subject: below --
2023-01-13 12:35 [Drbd-dev] [RESEND PATCH 0/8] Miscellaneous DRBD reorganization Christoph Böhmwalder
2023-01-13 12:35 ` [Drbd-dev] [PATCH 2/8] drbd: fix DRBD_VOLUME_MAX 65535 -> 65534 Christoph Böhmwalder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209145327.2272271-3-christoph.boehmwalder@linbit.com \
--to=christoph.boehmwalder@linbit.com \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox