Hi Gulam, Thank you for the patch! Yet something to improve: [auto build test ERROR on axboe-block/for-next] [also build test ERROR on song-md/md-next linus/master next-20221220] [cannot apply to device-mapper-dm/for-next v6.1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Gulam-Mohamed/block-Data-type-conversion-for-IO-accounting/20221221-121052 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next patch link: https://lore.kernel.org/r/20221221040506.1174644-2-gulam.mohamed%40oracle.com patch subject: [PATCH for-6.2/block V3 2/2] block: Change the granularity of io ticks from ms to ns config: i386-randconfig-a014-20221219 compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/afff703cb450ec3806aa1a27406d21fc4eaa1f43 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Gulam-Mohamed/block-Data-type-conversion-for-IO-accounting/20221221-121052 git checkout afff703cb450ec3806aa1a27406d21fc4eaa1f43 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/md/dm.c:507:6: error: redefinition of 'start_time' u64 start_time = (blk_queue_precise_io_stat(q) ? ^ drivers/md/dm.c:501:6: note: previous definition is here u64 start_time = io->start_time; ^ 1 error generated. vim +/start_time +507 drivers/md/dm.c 497 498 static void dm_io_acct(struct dm_io *io, bool end) 499 { 500 struct dm_stats_aux *stats_aux = &io->stats_aux; 501 u64 start_time = io->start_time; 502 struct mapped_device *md = io->md; 503 struct bio *bio = io->orig_bio; 504 unsigned int sectors; 505 struct request_queue *q = bdev_get_queue(bio->bi_bdev); 506 > 507 u64 start_time = (blk_queue_precise_io_stat(q) ? 508 nsecs_to_jiffies(io->start_time) : 509 io->start_time); 510 511 /* 512 * If REQ_PREFLUSH set, don't account payload, it will be 513 * submitted (and accounted) after this flush completes. 514 */ 515 if (bio_is_flush_with_data(bio)) 516 sectors = 0; 517 else if (likely(!(dm_io_flagged(io, DM_IO_WAS_SPLIT)))) 518 sectors = bio_sectors(bio); 519 else 520 sectors = io->sectors; 521 522 if (!end) 523 bdev_start_io_acct(bio->bi_bdev, sectors, bio_op(bio), 524 start_time); 525 else 526 bdev_end_io_acct(bio->bi_bdev, bio_op(bio), start_time); 527 528 if (static_branch_unlikely(&stats_enabled) && 529 unlikely(dm_stats_used(&md->stats))) { 530 sector_t sector; 531 532 if (likely(!dm_io_flagged(io, DM_IO_WAS_SPLIT))) 533 sector = bio->bi_iter.bi_sector; 534 else 535 sector = bio_end_sector(bio) - io->sector_offset; 536 537 dm_stats_account_io(&md->stats, bio_data_dir(bio), 538 sector, sectors, 539 end, start_time, stats_aux); 540 } 541 } 542 -- 0-DAY CI Kernel Test Service https://01.org/lkp