From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id C77164201C8 for ; Mon, 28 Aug 2023 19:07:45 +0200 (CEST) Date: Mon, 28 Aug 2023 19:07:44 +0200 From: Jan Kara To: Christian Brauner Message-ID: <20230828170744.iifdmaw732cfiauf@quack3> References: <20230818123232.2269-1-jack@suse.cz> <20230825-hubraum-gedreht-8c5c4db9330a@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825-hubraum-gedreht-8c5c4db9330a@brauner> Cc: Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Jan Kara , "Darrick J. Wong" , linux-nvme@lists.infradead.org, Joseph Qi , dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, Jack Wang , Alasdair Kergon , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, Sergey Senozhatsky , Christoph Hellwig , xen-devel@lists.xenproject.org, Gao Xiang , Christian Borntraeger , Kent Overstreet , Sven Schnelle , linux-pm@vger.kernel.org, Mike Snitzer , Chao Yu , Joern Engel , reiserfs-devel@vger.kernel.org, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, David Sterba , Jaegeuk Kim , Trond Myklebust , Jens Axboe , linux-raid@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, Ted Tso , linux-mm@kvack.org, Song Liu , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Minchan Kim , ocfs2-devel@oss.oracle.com, Anna Schumaker , linux-fsdevel@vger.kernel.org, "Md. Haris Iqbal" , Andrew Morton , linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org Subject: Re: [Drbd-dev] [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri 25-08-23 15:32:47, Christian Brauner wrote: > On Wed, Aug 23, 2023 at 12:48:11PM +0200, Jan Kara wrote: > > Hello, > > > > this is a v3 of the patch series which implements the idea of blkdev_get_by_*() > > calls returning bdev_handle which is then passed to blkdev_put() [1]. This > > makes the get and put calls for bdevs more obviously matching and allows us to > > propagate context from get to put without having to modify all the users > > (again!). In particular I need to propagate used open flags to blkdev_put() to > > be able count writeable opens and add support for blocking writes to mounted > > block devices. I'll send that series separately. > > > > The series is based on Christian's vfs tree as of today as there is quite > > some overlap. Patches have passed some reasonable testing - I've tested block > > changes, md, dm, bcache, xfs, btrfs, ext4, swap. More testing or review is > > always welcome. Thanks! I've pushed out the full branch to: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git bdev_handle > > > > to ease review / testing. Since there were not many comments for v2 and > > Christoph has acked the series I think we should start discussing how to merge > > the series. Most collisions with this series seem to happen in the filesystems > > area so VFS tree would seem as the least painful way to merge this. Jens, > > I really do like this series especially struct bdev_handle and moving > the mode bits in there. I'll happily take this. So far there have only > been minor things that can easily be fixed. Thanks. Since Al is fine with just doing a potential conversion to 'struct file' as a handle on top of this series (it will be dumb Coccinelle replacement) I think we can go ahead with the series as is. As you said there will be some conflicts in btrfs and I've learned about f2fs conflicts as well so I can rebase & repost the series on top of rc1 to make life easier for you. Honza -- Jan Kara SUSE Labs, CR