Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Jens Axboe" <axboe@kernel.dk>,
	"Mike Snitzer" <snitzer@kernel.org>,
	"Mikulas Patocka" <mpatocka@redhat.com>,
	"Song Liu" <song@kernel.org>, "Yu Kuai" <yukuai3@huawei.com>,
	"Philipp Reisner" <philipp.reisner@linbit.com>,
	"Lars Ellenberg" <lars.ellenberg@linbit.com>,
	"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: dm-devel@lists.linux.dev, linux-block@vger.kernel.org,
	linux-raid@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: [PATCH 04/16] md: add queue limit helpers
Date: Mon, 26 Feb 2024 11:29:52 +0100	[thread overview]
Message-ID: <20240226103004.281412-5-hch@lst.de> (raw)
In-Reply-To: <20240226103004.281412-1-hch@lst.de>

Add a few helpers that wrap the block queue limits API for use in MD.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/md.c | 37 +++++++++++++++++++++++++++++++++++++
 drivers/md/md.h |  3 +++
 2 files changed, 40 insertions(+)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 75266c34b1f99b..23823823f80c6b 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5699,6 +5699,43 @@ static const struct kobj_type md_ktype = {
 
 int mdp_major = 0;
 
+/* stack the limit for all rdevs into lim */
+void mddev_stack_rdev_limits(struct mddev *mddev, struct queue_limits *lim)
+{
+	struct md_rdev *rdev;
+
+	rdev_for_each(rdev, mddev) {
+		queue_limits_stack_bdev(lim, rdev->bdev, rdev->data_offset,
+					mddev->gendisk->disk_name);
+	}
+}
+EXPORT_SYMBOL_GPL(mddev_stack_rdev_limits);
+
+/* apply the extra stacking limits from a new rdev into mddev */
+int mddev_stack_new_rdev(struct mddev *mddev, struct md_rdev *rdev)
+{
+	struct queue_limits lim = queue_limits_start_update(mddev->queue);
+
+	queue_limits_stack_bdev(&lim, rdev->bdev, rdev->data_offset,
+				mddev->gendisk->disk_name);
+	return queue_limits_commit_update(mddev->queue, &lim);
+}
+EXPORT_SYMBOL_GPL(mddev_stack_new_rdev);
+
+/* update the optimal I/O size after a reshape */
+void mddev_update_io_opt(struct mddev *mddev, unsigned int nr_stripes)
+{
+	struct queue_limits lim;
+	int ret;
+
+	blk_mq_freeze_queue(mddev->queue);
+	lim = queue_limits_start_update(mddev->queue);
+	lim.io_opt = lim.io_min * nr_stripes;
+	ret = queue_limits_commit_update(mddev->queue, &lim);
+	blk_mq_unfreeze_queue(mddev->queue);
+}
+EXPORT_SYMBOL_GPL(mddev_update_io_opt);
+
 static void mddev_delayed_delete(struct work_struct *ws)
 {
 	struct mddev *mddev = container_of(ws, struct mddev, del_work);
diff --git a/drivers/md/md.h b/drivers/md/md.h
index 8d881cc597992f..25b19614aa3239 100644
--- a/drivers/md/md.h
+++ b/drivers/md/md.h
@@ -860,6 +860,9 @@ void md_autostart_arrays(int part);
 int md_set_array_info(struct mddev *mddev, struct mdu_array_info_s *info);
 int md_add_new_disk(struct mddev *mddev, struct mdu_disk_info_s *info);
 int do_md_run(struct mddev *mddev);
+void mddev_stack_rdev_limits(struct mddev *mddev, struct queue_limits *lim);
+int mddev_stack_new_rdev(struct mddev *mddev, struct md_rdev *rdev);
+void mddev_update_io_opt(struct mddev *mddev, unsigned int nr_stripes);
 
 extern const struct block_device_operations md_fops;
 
-- 
2.39.2


  parent reply	other threads:[~2024-02-26 11:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 10:29 atomic queue limit updates for stackable devices v2 Christoph Hellwig
2024-02-26 10:29 ` [PATCH 01/16] block: add a queue_limits_set helper Christoph Hellwig
2024-02-26 10:29 ` [PATCH 02/16] block: add a queue_limits_stack_bdev helper Christoph Hellwig
2024-02-26 10:29 ` [PATCH 03/16] dm: use queue_limits_set Christoph Hellwig
2024-02-26 10:29 ` Christoph Hellwig [this message]
2024-02-26 11:38   ` [PATCH 04/16] md: add queue limit helpers Yu Kuai
2024-02-27 14:36     ` Christoph Hellwig
2024-02-28  1:38       ` Yu Kuai
2024-02-26 10:29 ` [PATCH 05/16] md/raid0: use the atomic queue limit update APIs Christoph Hellwig
2024-02-26 10:29 ` [PATCH 06/16] md/raid1: " Christoph Hellwig
2024-02-26 11:29   ` Yu Kuai
2024-02-27 15:26     ` Christoph Hellwig
2024-02-27 21:54       ` Song Liu
2024-02-28  1:42         ` Yu Kuai
2024-02-26 10:29 ` [PATCH 07/16] md/raid10: " Christoph Hellwig
2024-02-26 10:29 ` [PATCH 08/16] md/raid5: " Christoph Hellwig
2024-02-26 10:29 ` [PATCH 09/16] block: remove disk_stack_limits Christoph Hellwig
2024-02-26 10:29 ` [PATCH 10/16] drbd: pass the max_hw_sectors limit to blk_alloc_disk Christoph Hellwig
2024-03-03 15:14   ` drbd queue limits conversion ping Christoph Hellwig
2024-03-04 15:31     ` Philipp Reisner
2024-03-05  9:39       ` Philipp Reisner
2024-03-05 13:38         ` Christoph Hellwig
2024-02-26 10:29 ` [PATCH 11/16] drbd: refactor drbd_reconsider_queue_parameters Christoph Hellwig
2024-02-26 10:30 ` [PATCH 12/16] drbd: refactor the backing dev max_segments calculation Christoph Hellwig
2024-02-26 10:30 ` [PATCH 13/16] drbd: merge drbd_setup_queue_param into drbd_reconsider_queue_parameters Christoph Hellwig
2024-02-26 10:30 ` [PATCH 14/16] drbd: don't set max_write_zeroes_sectors in decide_on_discard_support Christoph Hellwig
2024-02-26 10:30 ` [PATCH 15/16] drbd: split out a drbd_discard_supported helper Christoph Hellwig
2024-02-26 10:30 ` [PATCH 16/16] drbd: atomically update queue limits in drbd_reconsider_queue_parameters Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240226103004.281412-5-hch@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=christoph.boehmwalder@linbit.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=philipp.reisner@linbit.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox