From: I-HSIN CHENG <richard120310@gmail.com>
To: philipp.reisner@linbit.com
Cc: lars.ellenberg@linbit.com, I-HSIN CHENG <richard120310@gmail.com>,
linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: [PATCH] lru_cache: Initialize hlist_head in lc_create
Date: Mon, 11 Mar 2024 11:44:01 +0800 [thread overview]
Message-ID: <20240311034401.234854-1-richard120310@gmail.com> (raw)
Use INIT_HLIST_HEAD to perform the initialization for each pointer to
struct list_head in the variable "slot" to provide more safety and
prevent possible bugs from uninitialized behavior.
Signed-off-by: I-HSIN CHENG <richard120310@gmail.com>
---
lib/lru_cache.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/lru_cache.c b/lib/lru_cache.c
index b3d918761..ae122792e 100644
--- a/lib/lru_cache.c
+++ b/lib/lru_cache.c
@@ -105,6 +105,9 @@ struct lru_cache *lc_create(const char *name, struct kmem_cache *cache,
if (!lc)
goto out_fail;
+ for (int i = 0; i < e_count; i++)
+ INIT_HLIST_HEAD(slot + i);
+
INIT_LIST_HEAD(&lc->in_use);
INIT_LIST_HEAD(&lc->lru);
INIT_LIST_HEAD(&lc->free);
--
2.34.1
next reply other threads:[~2024-03-11 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 3:44 I-HSIN CHENG [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-11 3:07 [PATCH] lru_cache: Initialize hlist_head in lc_create I-HSIN CHENG
2024-04-16 13:42 ` Lars Ellenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311034401.234854-1-richard120310@gmail.com \
--to=richard120310@gmail.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox