From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 68E6F163175 for ; Sat, 9 May 2026 02:19:40 +0200 (CEST) Date: Fri, 8 May 2026 17:19:37 -0700 From: Jakub Kicinski To: Christoph =?UTF-8?B?QsO2aG13YWxkZXI=?= Subject: Re: [PATCH v3 0/2] drbd: switch from genl_magic to YNL Message-ID: <20260508171937.1c9419f5@kernel.org> In-Reply-To: <20260506124541.1951772-1-christoph.boehmwalder@linbit.com> References: <20260506124541.1951772-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Jens Axboe , Donald Hunter , netdev@vger.kernel.org, Philipp Reisner , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Eric Dumazet , Lars Ellenberg , drbd-dev@lists.linbit.com List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 6 May 2026 14:45:39 +0200 Christoph B=C3=B6hmwalder wrote: > DRBD's genetlink interface was defined using a custom multi-include > macro system, genl_magic_{func,struct}.h. This system generated struct > definitions, netlink policies, serialization functions and more > from a single "magic" header. > It never really caught on; DRBD is its only user, its internal macro > jungle is next to impossible to understand, and even harder to debug. >=20 > This series replaces it with the standard solution, YNL. > The *_gen.[ch] files were created with a modified YNL generator, but > these modifications are not shipped because the current DRBD family is > effectively frozen. >=20 > Note: this family primarily aims for compatibility with existing > userspace. The next planned step is a new (also YNL-based) family, > "drbd2", which will implement all the actual modern recommendations for > new netlink families. FWIW: Acked-by: Jakub Kicinski