From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 32D78420621 for ; Mon, 17 Jun 2024 12:40:03 +0200 (CEST) Message-ID: <293c79ef-43fe-4a08-8e2d-54aa61d04d43@suse.de> Date: Mon, 17 Jun 2024 12:40:00 +0200 MIME-Version: 1.0 Subject: Re: [PATCH 17/26] block: move the stable_writes flag to queue_limits To: Christoph Hellwig , Jens Axboe References: <20240617060532.127975-1-hch@lst.de> <20240617060532.127975-18-hch@lst.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20240617060532.127975-18-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: nvdimm@lists.linux.dev, "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , linux-mtd@lists.infradead.org, Vineeth Vijayan , Alasdair Kergon , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , Geert Uytterhoeven , Yu Kuai , dm-devel@lists.linux.dev, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Damien Le Moal , Mikulas Patocka , xen-devel@lists.xenproject.org, ceph-devel@vger.kernel.org, Ming Lei , linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, "Martin K. Petersen" , linux-mmc@vger.kernel.org, Philipp Reisner , virtualization@lists.linux.dev, Lars Ellenberg , linuxppc-dev@lists.ozlabs.org, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 6/17/24 08:04, Christoph Hellwig wrote: > Move the stable_writes flag into the queue_limits feature field so that > it can be set atomically with the queue frozen. > > The flag is now inherited by blk_stack_limits, which greatly simplifies > the code in dm, and fixed md which previously did not pass on the flag > set on lower devices. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Damien Le Moal > --- > block/blk-mq-debugfs.c | 1 - > block/blk-sysfs.c | 29 +---------------------------- > drivers/block/drbd/drbd_main.c | 5 ++--- > drivers/block/rbd.c | 9 +++------ > drivers/block/zram/zram_drv.c | 2 +- > drivers/md/dm-table.c | 19 ------------------- > drivers/md/raid5.c | 6 ++++-- > drivers/mmc/core/queue.c | 5 +++-- > drivers/nvme/host/core.c | 9 +++++---- > drivers/nvme/host/multipath.c | 4 ---- > drivers/scsi/iscsi_tcp.c | 8 ++++---- > include/linux/blkdev.h | 9 ++++++--- > 12 files changed, 29 insertions(+), 77 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich