From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.fusionio.com (mx1.fusionio.com [64.244.102.30]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 760611059369 for ; Sun, 7 Nov 2010 13:00:53 +0100 (CET) Message-ID: <4CD69163.1030407@fusionio.com> Date: Sun, 7 Nov 2010 12:45:39 +0100 From: Jens Axboe MIME-Version: 1.0 To: Mike Snitzer References: <1288985241-3515-1-git-send-email-snitzer@redhat.com> In-Reply-To: <1288985241-3515-1-git-send-email-snitzer@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: "linux-fsdevel@vger.kernel.org" , Neil Brown , "linux-kernel@vger.kernel.org" , "drbd-dev@lists.linbit.com" Subject: Re: [Drbd-dev] [PATCH] block: read i_size with i_size_read() List-Id: Coordination of development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2010-11-05 20:27, Mike Snitzer wrote: > Convert direct reads of an inode's i_size to using i_size_read(). > > i_size_{read,write} use a seqcount to protect reads from accessing > incomple writes. Concurrent i_size_write()s require mutual exclussion > to protect the seqcount that is used by i_size_{read,write}. But > i_size_read() callers do not need to use additional locking. Thanks Mike, I'll queue this up. -- Jens Axboe