Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: Jens Axboe <jaxboe@fusionio.com>
To: Or Gerlitz <ogerlitz@voltaire.com>
Cc: Lars Ellenberg <lars.ellenberg@linbit.com>,
	Philipp Reisner <philipp.reisner@linbit.com>,
	"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>
Subject: Re: [Drbd-dev] drbd: clean reference to old kernels
Date: Thu, 13 Jan 2011 14:57:02 +0100	[thread overview]
Message-ID: <4D2F04AE.8010007@fusionio.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1101131124380.19218@zuben.voltaire.com>

On 2011-01-13 10:34, Or Gerlitz wrote:
> drop code present under #ifdef which is relevant to 2.6.28 and below
> 
> Signed-off-by: Or Gerlitz <ogerlitz@voltaire.com>
> 
> ---
> 
> Philipp, I haven't noted if/where the drbd updates for 2.6.38 were posted,
> have them? do you typically post the pull request to LKML or there's a lower
> volume mailing list where this can be tracked?
> 
> diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
> index 11a75d3..85f6cf6 100644
> --- a/drivers/block/drbd/drbd_req.c
> +++ b/drivers/block/drbd/drbd_req.c
> @@ -1074,9 +1074,6 @@ int drbd_make_request_26(struct request_queue *q, struct bio *bio)
>  		const int mask = sps - 1;
>  		const sector_t first_sectors = sps - (sect & mask);
>  		bp = bio_split(bio,
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,28)
> -				bio_split_pool,
> -#endif
>  				first_sectors);
> 
>  		/* we need to get a "reference count" (ap_bio_cnt)

Thanks, that should die. Preferably the line could now be collapsed into
a single line as well.

-- 
Jens Axboe


  reply	other threads:[~2011-01-13 13:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-13  9:34 [Drbd-dev] drbd: clean reference to old kernels Or Gerlitz
2011-01-13 13:57 ` Jens Axboe [this message]
2011-01-13 14:27 ` [Drbd-dev] [PATCH v2] " Or Gerlitz
2011-01-13 15:28   ` Lars Ellenberg
2011-01-23 12:35   ` [Drbd-dev] [PATCH v3] " Or Gerlitz
2011-01-13 15:04 ` [Drbd-dev] " Philipp Reisner
2011-01-13 15:46   ` Or Gerlitz
2011-01-13 16:07     ` Philipp Reisner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2F04AE.8010007@fusionio.com \
    --to=jaxboe@fusionio.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=ogerlitz@voltaire.com \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox